test(review): seed the live pull_requests ledger for the submission-cadence tests - #9096
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🛑 LoopOver review result - reject/close recommendedReview updated: 2026-07-26 17:24:37 UTC
Review summary Nits — 3 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
LoopOver is closing this pull request on the maintainer's behalf (No linked issue detected). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
…adence tests JSONbored#9041 moved getSubmitterCadence off review_targets (frozen at the self-host cutover) to read the live pull_requests table, but the cadence test's local seed helper still wrote only review_targets. The query therefore read zero samples, so the machine-paced submitter assertion failed on main and broke validate-tests for every branch. Seed pull_requests alongside review_targets in the cadence helper so the signal has the live data it now reads, without disturbing the merged/approved review_targets rows that keep the quality signal neutral.
Problem
The
submission-cadence signal (#4514)tests intest/unit/reputation-wiring.test.tsfail on currentmain(theFLAG-ON: true for a machine-paced submittercase assertstruebut getsfalse), which failsvalidate-testsfor every branch cut from main.Root cause: #9041 deliberately moved
getSubmitterCadence(src/review/submitter-reputation.ts) offreview_targets— which stopped receiving writes at the 2026-06-22 self-host cutover — to read the livepull_requestsledger:But the cadence
describeblock's localseedReviewTargethelper still seeds onlyreview_targets, so the cadence query reads zero samples →count 0→isMachinePacedCadencereturnsfalse→ the machine-paced assertion fails.Fix
Seed
pull_requestsalongsidereview_targetsin that helper so the cadence signal has the live data it now reads. The existing merged/approvedreview_targetsrows are kept untouched — they are what hold the quality signal neutral so only cadence can trip these two tests. Only the assertion's data source is corrected; the assertions themselves are unchanged.Verification
test/unit/reputation-wiring.test.ts: 36/36 pass (was 1 failed). The machine-paced test now correctly detects the sub-10-minute median gap, and the human-pace test still readsfalse. Test-only change.