Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/queue/review-evasion.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@
// the file's own module-split sequence, after transient-locks.ts, signal-snapshot.ts,
// duplicate-detection.ts, and slop-detection.ts). Only the top-level "maybe*" entry points are
// exported (each called from exactly one webhook-handler call site still in processors.ts) -- every other
// function/type/constant here (withPrActuationLock, evaluateCloseEnforcementGate, hasMaintainerOrOwnerPermission,
// the "close*If*" implementations, ReopenRecloseOutcome, REVIEW_EVASION_CLOSED_EVENT_TYPE) is private to this
// file, since none of them had any caller outside this cluster in the original file either.
// function/constant here (withPrActuationLock, evaluateCloseEnforcementGate, hasMaintainerOrOwnerPermission,
// the "close*If*" implementations, REVIEW_EVASION_CLOSED_EVENT_TYPE) is private to this file, since none of
// them had any caller outside this cluster in the original file either. The one exception is the exported
// `ReopenRecloseOutcome` type, which processors.ts imports and consumes -- reshaping it needs a cross-file
// impact check there.
// maybeCloseSynchronizeAmendment (#synchronize-close-policy) is a later, 6th addition alongside the original
// 5 extracted here -- same shape and reasoning as its siblings, added directly to this module rather than
// growing processors.ts again.
Expand Down
2 changes: 1 addition & 1 deletion src/review/linked-issue-label-propagation-fetch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type MaintainerCheckResult = "maintainer" | "not_maintainer" | "inconclusive";
/** Whether `login` holds a maintainer-equivalent permission on `repoFullName` -- the literal repo owner,
* a fleet-operator in the global `ADMIN_GITHUB_LOGINS` allowlist, or a live GitHub collaborator with
* admin/maintain/write access (#priority-linked-issue-gate-ownership). Mirrors
* `hasMaintainerOrOwnerPermission` in `src/queue/processors.ts` (kept as its own copy here rather than
* `hasMaintainerOrOwnerPermission` in `src/queue/review-evasion.ts` (kept as its own copy here rather than
* imported, since that one is private to a file this module's header comment explicitly must NOT pull
* into its import graph -- see the file-level comment above). A CONFIRMED answer (including a 404,
* `getRepositoryCollaboratorPermission`'s real "not a collaborator" signal) resolves deterministically;
Expand Down