fix(orb): correct two false 'private to this file' location comments

[kai392]

Fixes #8650

Root cause

Two module comments make checkable, false location claims:

1. src/queue/review-evasion.ts's header listed ReopenRecloseOutcome among names "private to this file, since none of them had any caller outside this cluster." But export type ReopenRecloseOutcome (line 333) is imported by src/queue/processors.ts:403 and consumed at processors.ts:6175. Every other name in that parenthetical is correctly unexported — only this one broke the stated invariant, so a future contributor reshaping the type could reasonably skip the cross-file impact check processors.ts actually requires.

2. src/review/linked-issue-label-propagation-fetch.ts:44 said its local copy "Mirrors hasMaintainerOrOwnerPermission in src/queue/processors.ts" — but that function lives in src/queue/review-evasion.ts:553 (unexported), not processors.ts.

Fix

• Removed ReopenRecloseOutcome from review-evasion.ts's "private to this file" list and added a note that it is exported and consumed by processors.ts, so reshaping it needs a cross-file impact check there.
• Corrected the linked-issue-label-propagation-fetch.ts comment to name review-evasion.ts as the real location.

Both are comment-only; no behavioral change.

Verification of the corrected claims

$ grep -n "export type ReopenRecloseOutcome" src/queue/review-evasion.ts
333:export type ReopenRecloseOutcome = "reclosed" | "allowed";
$ grep -n "ReopenRecloseOutcome" src/queue/processors.ts
403:  type ReopenRecloseOutcome,
6175:    const reopenOutcome: ReopenRecloseOutcome =
$ grep -rn "function hasMaintainerOrOwnerPermission" src/queue/*.ts
src/queue/review-evasion.ts:553:async function hasMaintainerOrOwnerPermission(...)

Coverage

Per the issue: a doc/comment-accuracy fix with no behavioral change and no new runtime branch, so no test is required. The diff adds no coverable source lines, so codecov/patch is not affected. Both changed files are imported by existing test/** suites (e.g. agent-action-executor.test.ts, linked-issue-label-propagation-fetch.test.ts), so the scoped CI run still exercises src/**.

Validation

• npm run typecheck clean; branch cut from current main; git diff --check clean

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (b83b78c) to head (ecfc126).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8707      +/-   ##
==========================================
+ Coverage   90.56%   90.63%   +0.07%     
==========================================
  Files          96       98       +2     
  Lines       22490    22815     +325     
  Branches     3884     4024     +140     
==========================================
+ Hits        20367    20678     +311     
- Misses       1945     1948       +3     
- Partials      178      189      +11     

Flag	Coverage Δ
backend	95.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/queue/review-evasion.ts	94.59% <ø> (ø)
src/review/linked-issue-label-propagation-fetch.ts	100.00% <ø> (ø)

[loopover-orb]

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-26 00:03:25 UTC}

2 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This PR corrects two false comment claims: removes `ReopenRecloseOutcome` from review-evasion.ts's "private to this file" list (it's actually exported and consumed by processors.ts:403/6175) and fixes a mislocated reference to `hasMaintainerOrOwnerPermission`, pointing it to review-evasion.ts instead of processors.ts. Both changes are verified against the full file content shown — the export and cross-file usage are real, and the corrected location matches where the function is actually defined. This is a comment-only fix with no behavioral change, so the lack of test coverage is appropriate here.

Nits — 3 non-blocking

• The PR description states 'Fixes fix(orb): review-evasion.ts header falsely claims ReopenRecloseOutcome is private to the file #8650' but the issue-scope enforcement policy requires confirming this is an eligible, maintainer-linked issue rather than a self-filed pretext for a trivial comment fix.
• Consider whether such narrow comment-accuracy fixes should be batched with other documentation corrections rather than opened as individual PRs, to reduce review overhead for genuinely single-line changes.
• Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8650
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 149 registered-repo PR(s), 78 merged, 7 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	kai392; Gittensor profile; 149 PR(s), 7 issue(s).
Improvement	ℹ️ None detected	risk: low · value: none · LLM: minor

Linked issue satisfaction

Addressed
The diff removes ReopenRecloseOutcome from the 'private to this file' list in review-evasion.ts and adds a note that it's exported and consumed by processors.ts, and corrects the linked-issue-label-propagation-fetch.ts comment to point to review-evasion.ts instead of processors.ts, matching both required deliverables.

Review context

• Author: kai392
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, Cuda, JavaScript, Kotlin, Perl, TypeScript, Vue
• Official Gittensor activity: 149 PR(s), 7 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.