feat(mcp): register loopover_get_automation_state stdio tool - #7949
Closed
xfodev wants to merge 2 commits into
Closed
feat(mcp): register loopover_get_automation_state stdio tool#7949xfodev wants to merge 2 commits into
xfodev wants to merge 2 commits into
Conversation
…ed#7752) The loopover_get_automation_state tool already exposed a remote MCP surface (src/mcp/server.ts) and a `maintain automation-state` CLI verb, but had no local stdio MCP registration, unlike its maintain-family siblings. Add the registerStdioTool block + STDIO_TOOL_DESCRIPTORS entry in packages/loopover-mcp/bin/loopover-mcp.ts, proxying the existing GET /v1/repos/:owner/:repo/automation-state route via apiGet. Covers the new stdio lines with an in-process mcp-cli test that drives the tool through a real MCP client over InMemoryTransport, and bumps the stdio tool-count pin from 89 to 90 with the output-schema entry. Closes JSONbored#7752
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Contributor
|
This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included. |
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7949 +/- ##
=======================================
Coverage ? 11.38%
=======================================
Files ? 1
Lines ? 2188
Branches ? 838
=======================================
Hits ? 249
Misses ? 1921
Partials ? 18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
Superseded — #7752 was merged upstream while this was in CI; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loopover_get_automation_statealready exposed a remote MCP tool (src/mcp/server.ts) and amaintain automation-stateCLI verb, but had no local stdio MCP registration — unlike every other tool in itsmaintainfamily. This adds the missing stdio surface:registerStdioTool("loopover_get_automation_state", …)+ itsSTDIO_TOOL_DESCRIPTORSentry inpackages/loopover-mcp/bin/loopover-mcp.ts, mirroring the mergedloopover_get_gate_config_effectivesibling:ownerRepoinput shape,apiGetproxy,toolResultwrapper.GET /v1/repos/:owner/:repo/automation-stateroute — the same route the remote tool and CLI already use. No new REST route, no new CLI verb, nosrc/mcp/server.tschange.Tests
test/unit/mcp-cli-automation-state.test.ts(new, in-process): drives the tool through a real MCPClientoverInMemoryTransportagainst a fixture server, asserting the tool is listed and the proxied request hits the automation-state route.test/unit/mcp-tool-rename-aliases.test.ts: stdio tool-count pin bumped89 → 90(all three assertions) with a running-log comment.test/unit/mcp-output-schemas.test.ts: added the tool to the output-schema coverage set.mcp-tool-categories) and completion-spec parity (mcp-cli-completion-spec) tests pass unchanged.UI Evidence
N/A — backend MCP tooling only; no
apps/**files touched.Validation
tsc --noEmitclean (my files).mcp-tool-rename-aliases,mcp-tool-categories,mcp-output-schemas,mcp-cli-completion-specpass; the live server registers exactly 90 tools.main; no base conflict.Closes #7752