Skip to content

feat(mcp): register loopover_watch_issues as a local stdio tool (#7763) - #7948

Closed
kai392 wants to merge 1 commit into
JSONbored:mainfrom
kai392:feat/7763-stdio-watch-issues
Closed

feat(mcp): register loopover_watch_issues as a local stdio tool (#7763)#7948
kai392 wants to merge 1 commit into
JSONbored:mainfrom
kai392:feat/7763-stdio-watch-issues

Conversation

@kai392

@kai392 kai392 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #7763

Test plan

  • build:mcp + typecheck + branding-drift:check
  • vitest coverage: mcp-cli-watch-issues-tool, mcp-tool-rename-aliases (patch ~100% on changed executable lines)
  • CI green on this PR

@kai392
kai392 requested a review from JSONbored as a code owner July 21, 2026 20:44
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

Closes JSONbored#7763

Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 21, 2026
@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - fixes required

Review updated: 2026-07-21 21:00:40 UTC

3 files · 1 AI reviewer · no blockers · CI failing · blocked

🛑 Suggested Action - Fix Blockers

Review summary
Adds a stdio twin of the existing remote loopover_watch_issues tool, proxying the same /v1/contributors/:login/watches REST routes via a new shared manageIssueWatches helper, and bumps the tool-count pins from 89 to 90. The wiring is straightforward and mirrors the established registerStdioTool pattern (e.g. #7808), with a new test file exercising list/watch/unwatch/missing-repoFullName paths in-process. The 'leaked secret' flagged by the external brief is just a fixture placeholder token (`in-process-token`), not a real credential.

Nits — 6 non-blocking
  • The 'labels' input isn't validated against the API's accepted label set the way repoFullName length bounds are (packages/loopover-mcp/bin/loopover-mcp.ts:461-462); confirm the API rejects malformed labels rather than silently accepting them.
  • 3/200/50 in the new watchIssuesShape (loopover-mcp.ts:461-462) are unexplained magic numbers — worth a one-line comment noting they mirror the remote watchIssuesShape bounds, similar to how WRITE_TOOL_* constants are named elsewhere in this file.
  • The `input: any` parameter on the registerStdioTool handler (loopover-mcp.ts:2328) loses type safety zod's watchIssuesShape would otherwise provide — other handlers in this file follow the same any-typed pattern so it's consistent, but worth tightening if this file is ever revisited.
  • manageIssueWatches's action-required check message ('${action} requires repoFullName.') is user-facing text for two different actions (watch/unwatch) bundled in one throw; minor readability nit only.
  • Consider extracting the login-scoped watches path building (`/v1/contributors/${encodeURIComponent(input.login)}/watches`) into a shared helper if a third caller appears, though two current call sites don't yet justify it.
  • Possible secret-shaped assignment in the diff (generic_secret_assignment) — Verify the value is not a real credential.

CI checks failing

  • validate
  • validate-tests (2)

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #7763
Related work ⚠️ 1 scoped overlap Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 60 registered-repo PR(s), 33 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kai392; Gittensor profile; 60 PR(s), 0 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The PR adds a registerStdioTool block for loopover_watch_issues following the described sibling pattern, uses stdioToolDescription for its description, and reuses a shared manageIssueWatches helper (built from the existing CLI's REST calls) rather than duplicating HTTP logic, plus updates tool-count tests accordingly.

Review context
  • Author: kai392
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: JavaScript, Kotlin, Perl, TypeScript, Vue
  • Official Gittensor activity: 60 PR(s), 0 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (PR #7949)
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests (2))). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register loopover_watch_issues as a local stdio MCP tool

2 participants