feat(dlq): add dead-letter job-type breakdown helper - #2602
Conversation
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-02 22:35:04 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2602 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 233 233
Lines 26077 26081 +4
Branches 9474 9474
=======================================
+ Hits 25041 25045 +4
Misses 425 425
Partials 611 611
🚀 New features to boost your workflow:
|
1f84356 to
c4d366c
Compare
Summary
countRecentDeadLettersByTypebeside the existing DLQ counter so the dashboard can aggregate recent dead letters byjobType.jobTypemetadata tounknownand return a deterministically sorted object shape for stable consumers.Closes #2082.
Part of #1208.
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:ciwas run end-to-end locally, which executed the lint, coverage, workers, MCP, REES, and UI validation steps above.npx vitest run test/unit/db-parsers.test.tswas also run while iterating on the new helper and tests.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
Not applicable; this PR only adds a backend repository helper and unit tests.
Notes
github_app.dlq_dead_letteredaudit metadata, groups byjobType, and keeps the key order deterministic with SQL ordering.