feat(miner-foundation): MinerGoalSpec type definitions (#2293)

[nickmopen]

Closes #2293.

Defines the TypeScript type surface for a repo's .gittensory-miner.yml — the miner-side analogue of the review-side .gittensory.yml focus manifest — in the shared @jsonbored/gittensory-engine package (per the phase's "shared logic lives in gittensory-engine" principle). Types only; the parser (raw-YAML validation + coercion) is a separate follow-up issue, mirroring how FocusManifest's type precedes its parser.

Deliverables

• src/miner-goal-spec.ts:
  • MinerGoalSpec — minerEnabled: boolean, wantedPaths: string[], blockedPaths: string[], preferredLabels: string[], maxConcurrentClaims: number, issueDiscoveryPolicy: "encouraged" | "neutral" | "discouraged". Field names/semantics that overlap the review side are carried over verbatim from .gittensory.yml.
  • DEFAULT_MINER_GOAL_SPEC — the safe defaults: minable by explicit opt-out (minerEnabled: true, so a public repo with no file is still minable), no path/label preferences, 1 concurrent claim, neutral discovery.
  • MinerIssueDiscoveryPolicy union.
  • JSDoc Default: X on every field, matching the .gittensory.yml.example convention.
• Exported from the package barrel.

Field list is intentionally small for this foundation phase (easy to add later, painful to remove once relied on). Unblocks the goal-model (#2304) and the parser issues.

Validation

npm test in packages/gittensory-engine (tsc build + node:test):

ℹ tests 18
ℹ pass 18
ℹ fail 0

Covered for this module: DEFAULT_MINER_GOAL_SPEC's exact runtime values and field surface; a compile-time check that it satisfies MinerGoalSpec (fails tsc if the shape drifts); and a lint-style test asserting every field documents a Default: in its JSDoc. No parser logic (out of scope). tsc clean under strict + noUncheckedIndexedAccess.

[loopover-orb]

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

_{Review updated: 2026-07-02 22:56:50 UTC}

4 files · 1 AI reviewer · no blockers · readiness 62/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
The change adds a narrow exported TypeScript type surface, default singleton, README note, and tests for the new repo config contract. The runtime default values, barrel export, and deep-freeze behavior are coherent with the stated types-only scope, and the tests exercise the public package entrypoint plus the field surface. I do not see a reachable correctness defect in the provided files.

Nits — 5 non-blocking

• nit: packages/gittensory-engine/src/miner-goal-spec.ts:24 uses `readonly string[]` for list fields while the PR description says `string[]`; either align the public type with the advertised contract or document that parsed specs are intentionally immutable.
• nit: packages/gittensory-engine/test/miner-goal-spec.test.ts:47 relies on a regex over source text for JSDoc coverage, which is fine as a lightweight guard but brittle if formatting changes around the type fields.
• packages/gittensory-engine/src/miner-goal-spec.ts:24: decide whether the parsed config object should be mutable by consumers; if not, update the issue/README language to call out readonly arrays explicitly.
• packages/gittensory-engine/test/miner-goal-spec.test.ts:47: keep the source-layout assertion, but consider tightening the regex to the `export type MinerGoalSpec = { ... }` body so future unrelated docs cannot accidentally satisfy it.
• Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#2293
Related work	⚠️ 3 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (size label size:M; 1 linked issue).
Validation posture	❌ 5/25	Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload	✅ 10/10	Author activity: 100 registered-repo PR(s), 65 merged, 1 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	nickmopen; Gittensor profile; 100 PR(s), 1 issue(s).
Gate result	✅ Passing	No configured blocker found.

Review context

• Author: nickmopen
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository registration is not available in the local Gittensory cache.
• Public profile languages: not available
• Official Gittensor activity: 100 PR(s), 1 issue(s).
• Related work: Items reference the same linked issue feat(dlq): per-job-type dead-letter breakdown helper for the DLQ dashboard #2082. (issue #2082, PR #2602)
• Related work: Titles/paths share 10 meaningful terms. (issue #2277, issue #2278)
• Related work: Titles/paths share 9 meaningful terms. (issue #2277, issue #2291)
• Additional title-only matches omitted; title-only overlap does not block.

Contributor next steps

• Review top overlaps.
• Add a concise scope and risk note.
• Await review-lane availability.
• Refresh registry data or choose a registered active repo.
• Check active issues and PRs before submitting.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review