Skip to content

fix(cli): declare release and DOM test dependencies - #1190

Open
c8dhjp4tyv-bit wants to merge 1 commit into
CodebuffAI:mainfrom
c8dhjp4tyv-bit:recreate/1109-cli-typecheck-dependencies
Open

fix(cli): declare release and DOM test dependencies#1190
c8dhjp4tyv-bit wants to merge 1 commit into
CodebuffAI:mainfrom
c8dhjp4tyv-bit:recreate/1109-cli-typecheck-dependencies

Conversation

@c8dhjp4tyv-bit

Copy link
Copy Markdown

Recreated on the rewritten main after #1109 was auto-closed during repository maintenance. The dependency declarations were ported onto the rewritten snapshot and bun.lock was regenerated with the current repository Bun version instead of copying the pre-rewrite lockfile.

Summary

  • declare tar, which the release launcher and wrapper safety tests import in the private CLI workspace
  • declare @types/react-dom, which the CLI's server-rendering tests require for typechecking
  • update bun.lock with the minimal dependency graph changes while preserving the rewritten upstream lockfile

tar intentionally remains a CLI workspace devDependency: the actual published wrappers (cli/release, cli/release-staging, and freebuff/cli/release) each already declare tar in their own runtime dependencies.

Validation

Prior validation before the history rewrite:

  • CLI typecheck passes with exit code 0
  • release wrapper repair test passes
  • DOM-rendering component tests pass
  • runtime smoke import confirms tar.c and renderToStaticMarkup resolve
  • verified the tar 7 lockfile graph keeps incompatible older consumers nested (tar-fs/chownr@1.1.4, lru-cache/yallist@4.0.0) rather than upgrading them transitively
  • git diff --check passes

For this recreated branch, Bun 1.3.14 regenerated the lockfile from the current rewritten main. The resulting diff remains exactly 2 files with the same 18+/2- lockfile and 3+/1- package-manifest scope as the final old branch.

c8dhjp4tyv-bit added a commit to c8dhjp4tyv-bit/freebuff that referenced this pull request Sep 1, 2026
@github-actions
github-actions Bot force-pushed the recreate/1109-cli-typecheck-dependencies branch from a01a061 to 5946830 Compare September 1, 2026 07:50
@codebuff-team

Copy link
Copy Markdown
Contributor

Thanks for tracking this back through the repo rewrite — that's a good-faith effort.

The substance is simple and plausible: cli/package.json was missing tar and @types/react-dom as declared devDependencies despite the CLI workspace tests apparently importing them, so bun install on a clean tree would have failed typecheck/test resolution. Declaring transitively-used packages explicitly is a reasonable and low-risk fix, and the lockfile diff looks minimal and mechanical (bumping tar to 7.x pulls chownr@3, minizlib, @isaacs/fs-minipass, yallist@5, while correctly leaving the older nested tar-fs/lru-cache deps pinned at their old versions rather than upgrading them transitively - that's the right call).

A few things a maintainer will want to verify before porting, since this can't be validated from the diff alone:

  1. Confirm tar is actually used directly by CLI workspace code/tests (not just transitively available before). If it's only used by the release wrapper scripts described in the body, double check whether those wrappers already vendor their own tar dependency, as your PR body claims - if so, this devDependency may be redundant rather than a fix for a real breakage.
  2. Verify the @types/react-dom addition doesn't mask an existing type error elsewhere (i.e., that it was truly missing, not silently resolved via hoisting before).
  3. Since bun.lock is machine generated, worth double-checking no other incidental version drift crept in beyond the described tar graph change.

Given the scope is tiny and mechanical, this is portable if the above holds up under a quick sanity check.

@codebuff-team codebuff-team added bot:triaged Classified by the community triage bot pr:port-candidate Worth porting into the private source tree labels Sep 1, 2026

Copy link
Copy Markdown
Author

Verified all three dependency concerns on the recreated branch with Bun 1.3.14. tar is directly required by cli/release-core/launcher.js and the CLI release wrapper safety test; each published wrapper package also declares its own runtime tar dependency. react-dom/server is directly imported by nine CLI component/test files. bun run --cwd cli typecheck completes successfully. The PR diff remains exactly two files (cli/package.json and bun.lock), 21 insertions / 3 deletions; the lockfile changes are the expected tar@7 graph plus @types/react-dom, including nested old chownr@1.1.4 and yallist@4.0.0 for incompatible existing consumers. git diff --check passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:triaged Classified by the community triage bot pr:port-candidate Worth porting into the private source tree

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants