fix(cli): declare release and DOM test dependencies - #1109
Closed
c8dhjp4tyv-bit wants to merge 9044 commits into
Closed
fix(cli): declare release and DOM test dependencies#1109c8dhjp4tyv-bit wants to merge 9044 commits into
c8dhjp4tyv-bit wants to merge 9044 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tar, which the release launcher and wrapper safety tests import in the private CLI workspace@types/react-dom, which the CLI's server-rendering tests require for typecheckingbun.lockwith the minimal dependency graph changestarintentionally remains a CLI workspace devDependency: the actual published wrappers (cli/release,cli/release-staging, andfreebuff/cli/release) each already declaretarin their own runtimedependencies.Validation
tar.candrenderToStaticMarkupresolvetar-fs/chownr@1.1.4,lru-cache/yallist@4.0.0) rather than upgrading them transitivelygit diff --checkpassesaction_required, so there is no completed GitHub CI result to claim yet