Skip to content

New next and previous buttons - #422

Merged
pavlenex merged 4 commits into
masterfrom
feature/next-previous-buttons
Jul 16, 2021
Merged

pavlenex merged 4 commits into
masterfrom
feature/next-previous-buttons

Conversation

@GBKS

@GBKS GBKS commented Jul 7, 2021 •

Copy link
Copy Markdown
Contributor

Added a new include for buttons at the bottom of each page to get to the next and previous pages. Added them to the pages in the "Getting started" section for now. If we like this solution, we can add it to other pages as well.

Preview (see bottom of the page).

Closes #372

Addresses #372 . Added a new include for buttons at the bottom of each page to get to the next and previous pages. Added them to the pages in the "Getting started" section for now.
@GBKS GBKS added Dev Development-focused tasks. Copy Task is about improving text. labels Jul 7, 2021
@GBKS GBKS self-assigned this Jul 7, 2021
@pavlenex

pavlenex commented Jul 7, 2021

Copy link
Copy Markdown
Contributor

It doesn't appear on top-level pages like Introduction or Getting Started or Onboarding is this on purpose if so, why?

@GBKS

GBKS commented Jul 7, 2021

Copy link
Copy Markdown
Contributor Author

@pavlenex I just added it to a few pages for now to see if we generally like this solution. If so, we can add it to all the other pages also, but I thought it might best to get some feedback first as it's a bunch of manual work.

@pavlenex

pavlenex commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

Got it @GBKS, sorry haven't looked at the diffs for this one, just tested it out.

tACK on both mobile and desktop.

pavlenex
pavlenex previously approved these changes Jul 8, 2021
@GBKS

GBKS commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

@pavlenex I added the buttons to the remaining files.

@pavlenex pavlenex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@pavlenex
pavlenex merged commit 2a5f76b into master Jul 16, 2021
@danielnordh
danielnordh deleted the feature/next-previous-buttons branch September 17, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text. Dev Development-focused tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a button for the > next chapter segment

2 participants