Skip to content

[PE-7226] Fix issues with confirmation screen - #13294

Merged
DejayJD merged 4 commits into
mainfrom
jd/fix-swap-confirmation-screen
Oct 22, 2025
Merged

[PE-7226] Fix issues with confirmation screen#13294
DejayJD merged 4 commits into
mainfrom
jd/fix-swap-confirmation-screen

Conversation

@DejayJD

@DejayJD DejayJD commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Description

  • Fixes issues with confirmation screen defaulting to USDC. The bug was that we put useWalletCoins in the wrong spot 💀, useTradeableCoins is just the list of all coins, useOwnedCoins is where it needed to go
  • This may solve some additional bugs tbh

How Has This Been Tested?

web:prod

@DejayJD
DejayJD requested a review from dylanjeffers October 22, 2025 16:28
@changeset-bot

changeset-bot Bot commented Oct 22, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: be60738

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylanjeffers I just reverted all the changes here - I'm assuming the only changes you made were just to get external wallets working, but if I blew away anything else lmk

@DejayJD
DejayJD merged commit 8eade23 into main Oct 22, 2025
4 of 9 checks passed
@DejayJD
DejayJD deleted the jd/fix-swap-confirmation-screen branch October 22, 2025 18:09
DejayJD added a commit that referenced this pull request Oct 23, 2025
### Description

- Fixes issues with confirmation screen defaulting to USDC. The bug was
that we put `useWalletCoins` in the wrong spot 💀, `useTradeableCoins` is
just the list of all coins, `useOwnedCoins` is where it needed to go
- This may solve some additional bugs tbh


### How Has This Been Tested?

web:prod
audius-infra pushed a commit that referenced this pull request Oct 25, 2025
[4b1ce10] [PE-7239] Fix issues due to stale local storage data (#13311) Dylan Jeffers
[7a88ddf] Artist coins page size 1000 (#13313) Reed
[3d246f6] Some additional analytics around wallets & launchpad (#13312) JD Francis
[f22659e] [PE-7238] Add analytics for external wallet swaps (#13309) JD Francis
[421a9e9] 💚🟢🐸🥬 (#13308) JD Francis
[ffb4af9] Fix wallet connect not triggering success in claim flow (#13305) JD Francis
[68fa1a4] [PE-7229] Fix referrer signup (#13306) Dylan Jeffers
[6ed86b5] Version Packages (#13254) github-actions[bot]
[b9b22cd] [PE-7204] Associate wallets on solana /relay calls (#13299) JD Francis
[ad01774] Revert "[PE-7211] Claim fees after connect" (#13303) JD Francis
[1819c1e] fix mobile ci (#13302) JD Francis
[afeceae] Fix AUDIO breakdown (#13298) Farid Salau
[68eace6] birdeye.so (#13301) Marcus Pasell
[30f3e66] [PE-7215] Add sol back into the list of tokens + Dont show 'add cash' (#13295) JD Francis
[6e74a41] Fix CI (#13297) Farid Salau
[e68b261] [PE-7212] Claim fees optimistic updates (#13290) Dylan Jeffers
[d1000f1] [PE-7211] Claim fees after connect (#13291) Dylan Jeffers
[f1f1e94] [PE-7210] Handle lowercase coin urls (#13284) Dylan Jeffers
[8eade23] [PE-7226] Fix issues with confirmation screen (#13294) JD Francis
[0b58a67] [PE-7198] Update mobile profile edit flow UI (#13271) Farid Salau
[dd17039] eth key exporter (#13293) alecsavvy
[a6d5e9d] Use production wAUDIO on stage (#13288) Marcus Pasell
[0bd603d] [PE-7213] Prevent claiming dust (#13289) Dylan Jeffers
[b4dde83] Add polling for audio balance changes (#13228) JD Francis
[315865f] Fix lint (#13285) Dylan Jeffers
[ee7ee7f] [PE-7209] External wallet coin dropdown (#13283) Dylan Jeffers
[d4f7649] [PE-7191] External wallet swap flow (#13276) JD Francis
[4a38e63] Rename asset to coin (#13275) Dylan Jeffers
[c3ffa17] Show DAMM V2 Fees in UI (#13280) Marcus Pasell
[172f129] Remove extra dbcpool arg (#13269) Ray Jacobson
[3dafa35] [PE-7199] Refactor buy/sell flow coin filtering logic  (#13272) Farid Salau
[c1d796d] [PE-7193] Announcement notifs link to artist coin explore (#13266) Reed
[3e561d2] [PE-7197] Update ArtistCoinHoverCard to include member vs creator  (#13270) Farid Salau
[50878b5] Small QA items (#13273) Farid Salau
[932fbdb] Remove search explore flag (#13261) Dylan Jeffers
[5da716e] [PE-7163] Redirect mispelled coins to 404 (#13274) Ray Jacobson
[6866949] Finalize mobile search explore (#13260) Dylan Jeffers
[0ec2f5f] [PE-7189] Add balance breakdown component  (#13262) Farid Salau
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants