[PE-7209] External wallet coin dropdown - #13283
Conversation
|
|
Just checked this locally, not quite working just yet - My wallet has SOL/USDC/CAPBOI/ABJONIAN so I should be seeing those 4 as my options |
| const solToken = TOKEN_LISTING_MAP.SOL | ||
| coinsMap.set(solToken.address, { | ||
| symbol: solToken.symbol, | ||
| name: solToken.name, | ||
| decimals: solToken.decimals, | ||
| balance: null, | ||
| address: solToken.address, | ||
| logoURI: solToken.logoURI, | ||
| isStablecoin: false | ||
| }) |
There was a problem hiding this comment.
I dont think this is problematic since our internal wallets shouldn't have any sol but if I'm reading this right, this technically means SOL could show up for internal wallets
There was a problem hiding this comment.
yeah, iirc we were thinking we may want this, but happy to drop if we dont want it. probably should drop it so we dont have to deal with sol limits etc?
| symbol: usdcToken.symbol, | ||
| name: usdcToken.name, | ||
| decimals: usdcToken.decimals, | ||
| balance: null, | ||
| address: env.USDC_MINT_ADDRESS, | ||
| logoURI: usdcToken.logoURI, | ||
| isStablecoin: true | ||
| }) |
There was a problem hiding this comment.
nit: ...usdcToken would do most of this
| if (context === 'pay') { | ||
| // For pay context, filter out USDC (users pay with artist coins) | ||
| filteredCoins = filteredCoins.filter((coin) => coin.symbol !== 'USDC') | ||
| } |
There was a problem hiding this comment.
nit: don't love how this is set up, seems like an odd mix of business logic into this hook. But its probably not worth changing
There was a problem hiding this comment.
fwiw this was already here, i just moved it out the artist-coin hook selector so it can operate on internal and external coins
| QUERY_KEYS.coins, | ||
| 'wallet', |
There was a problem hiding this comment.
dont like the random string here, also I think its own queryKey like walletCoins may just make more sense than coins > wallet
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
[4b1ce10] [PE-7239] Fix issues due to stale local storage data (#13311) Dylan Jeffers [7a88ddf] Artist coins page size 1000 (#13313) Reed [3d246f6] Some additional analytics around wallets & launchpad (#13312) JD Francis [f22659e] [PE-7238] Add analytics for external wallet swaps (#13309) JD Francis [421a9e9] 💚🟢🐸🥬 (#13308) JD Francis [ffb4af9] Fix wallet connect not triggering success in claim flow (#13305) JD Francis [68fa1a4] [PE-7229] Fix referrer signup (#13306) Dylan Jeffers [6ed86b5] Version Packages (#13254) github-actions[bot] [b9b22cd] [PE-7204] Associate wallets on solana /relay calls (#13299) JD Francis [ad01774] Revert "[PE-7211] Claim fees after connect" (#13303) JD Francis [1819c1e] fix mobile ci (#13302) JD Francis [afeceae] Fix AUDIO breakdown (#13298) Farid Salau [68eace6] birdeye.so (#13301) Marcus Pasell [30f3e66] [PE-7215] Add sol back into the list of tokens + Dont show 'add cash' (#13295) JD Francis [6e74a41] Fix CI (#13297) Farid Salau [e68b261] [PE-7212] Claim fees optimistic updates (#13290) Dylan Jeffers [d1000f1] [PE-7211] Claim fees after connect (#13291) Dylan Jeffers [f1f1e94] [PE-7210] Handle lowercase coin urls (#13284) Dylan Jeffers [8eade23] [PE-7226] Fix issues with confirmation screen (#13294) JD Francis [0b58a67] [PE-7198] Update mobile profile edit flow UI (#13271) Farid Salau [dd17039] eth key exporter (#13293) alecsavvy [a6d5e9d] Use production wAUDIO on stage (#13288) Marcus Pasell [0bd603d] [PE-7213] Prevent claiming dust (#13289) Dylan Jeffers [b4dde83] Add polling for audio balance changes (#13228) JD Francis [315865f] Fix lint (#13285) Dylan Jeffers [ee7ee7f] [PE-7209] External wallet coin dropdown (#13283) Dylan Jeffers [d4f7649] [PE-7191] External wallet swap flow (#13276) JD Francis [4a38e63] Rename asset to coin (#13275) Dylan Jeffers [c3ffa17] Show DAMM V2 Fees in UI (#13280) Marcus Pasell [172f129] Remove extra dbcpool arg (#13269) Ray Jacobson [3dafa35] [PE-7199] Refactor buy/sell flow coin filtering logic (#13272) Farid Salau [c1d796d] [PE-7193] Announcement notifs link to artist coin explore (#13266) Reed [3e561d2] [PE-7197] Update ArtistCoinHoverCard to include member vs creator (#13270) Farid Salau [50878b5] Small QA items (#13273) Farid Salau [932fbdb] Remove search explore flag (#13261) Dylan Jeffers [5da716e] [PE-7163] Redirect mispelled coins to 404 (#13274) Ray Jacobson [6866949] Finalize mobile search explore (#13260) Dylan Jeffers [0ec2f5f] [PE-7189] Add balance breakdown component (#13262) Farid Salau
2 participants
Description
When user has connected an external wallet, we display a list of artist coins with balance in the external wallet for buy/sell/swap