Adds line param to unsetVerticalIndent - #41
Merged
Conversation
…input-listener-for-inline
…ointer exception in caret movement listener
…mazon-q-eclipse into refactor-input-listener-for-inline
Contributor
|
Changes look good, but please merge |
breedloj
approved these changes
Sep 27, 2024
dingfeli
changed the base branch from
refactor-input-listener-for-inline
to
main
September 27, 2024 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Premise
In order to show the ghost text from a given suggestion without having it overlapped with user buffer thereafter, the line at which the suggestion was triggered needs to be indented vertically to make space for the suggestion ghost text. This was done in this change: #31.
Upon termination of preview, this vertical indent would need to be unset to revert the text widget back to its original state.
Description of changes:
The following changes were made in this PR. These changes were made based on the changes in #37:
unsetVerticalndentto specify the line number to which the operation is done (previously this was always the line below the current line the caret is on).Test
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.