Refactor input listener for inline - #37
Merged
Merged
Conversation
…input-listener-for-inline
…ointer exception in caret movement listener
…mazon-q-eclipse into refactor-input-listener-for-inline
breedloj
approved these changes
Sep 27, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Premise
The existing typeahead logic leverages a single verifyKey listener to verify all user input keystrokes.
This makes it the logic very convoluted and hard to deal with edge cases.
A refactor to separate the listener into verifyKey + verifyText would help clean up the / simplify the logic.
Description of changes:
With this change, the following bugs were fixed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.