Drop strict xfail on test_3d_source_streams now that #3111 fixed #3100#3179
Closed
brendancol wants to merge 1 commit into
Closed
Drop strict xfail on test_3d_source_streams now that #3111 fixed #3100#3179brendancol wants to merge 1 commit into
brendancol wants to merge 1 commit into
Conversation
Contributor
Author
|
Superseded by #3181, which landed the same xfail removal first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3177.
#3111 fixed the 2-D output buffer crash on 3-D streaming sources, and #3118 added a strict xfail expecting that crash. Each was green against the main it branched from; together they turn the XPASS into a failure, so main and every PR that syncs it are red.
The #3100 behavior is fixed, so this removes the xfail marker and the stale "once #3100 is fixed" comment, and lets the assertions run for real. All 15 tests in the file pass locally.