Add unit test for wolfSSH_RsaVerify#929
Open
yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Add unit test for wolfSSH_RsaVerify#929yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an internal unit test to ensure wolfSSH_RsaVerify() fails (returns WS_RSA_E) when the decoded signature digest has the correct size but incorrect contents, using a WOLFSSH_TEST_INTERNAL wrapper since wolfSSH_RsaVerify() is internal-only.
Changes:
- Expose
wolfSSH_TestRsaVerify()underWOLFSSH_TEST_INTERNAL(and!WOLFSSH_NO_RSA) for unit testing. - Add a new unit test
test_RsaVerify_BadDigest()that signs a correct DigestInfo and verifies failure when the expected DigestInfo is tampered. - Add required wolfCrypt RSA/ASN includes for the new unit test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| wolfssh/internal.h | Declares the internal-test wrapper wolfSSH_TestRsaVerify() behind WOLFSSH_TEST_INTERNAL. |
| tests/unit.c | Adds RSA verify negative/positive test coverage using a fixed RSA key and tampered DigestInfo. |
| src/internal.c | Implements wolfSSH_TestRsaVerify() wrapper calling wolfSSH_RsaVerify() with a fixed loc string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test that calls wolfSSH_RsaVerify with a signature whose decoded digest content is intentionally wrong (correct size, wrong bytes) and verifies that WS_RSA_E is returned.
Also, this adds the test helper in src/internal.c with WOLFSSH_TEST_INTERNAL guard because wolfSSH_RsaVerify() is hidden in internal.c.