Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets make distcheck / out-of-tree build test failures by ensuring regression tests and forwarding test scripts can locate required source-tree assets (keys and the expect driver) when executed from a build directory.
Changes:
- Update
tests/regress.cto includewolfssh/test.hand callChangeToWolfSshRoot()before running tests. - Update
scripts/fwd.testto locatescripts/fwd.test.expectvia$srcdirwhen available (Automake out-of-tree testing), falling back to..
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/regress.c | Changes working directory to the wolfSSH repo root so relative key paths resolve under distcheck. |
| scripts/fwd.test | Uses $srcdir to execute the expect test from the source tree during out-of-tree builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JacobBarthelmeh
assigned
ejohnstown and
JacobBarthelmeh and unassigned
JacobBarthelmeh and
ejohnstown
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.