feat(plugin): implement close method for plugin mode handling - #2347
Merged
Conversation
🦋 Changeset detectedLatest commit: c82442d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2347 +/- ##
==========================================
+ Coverage 92.70% 92.73% +0.02%
==========================================
Files 3 3
Lines 1001 1005 +4
Branches 311 312 +1
==========================================
+ Hits 928 932 +4
Misses 65 65
Partials 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| // For plugin usage the host (webpack-cli, webpack-dev-server, etc.) owns `compiler.watch()`, | ||
| // so there is no `watching` of our own to close (`compiler.close()` on the host handles it) | ||
| if (!filledContext.watching) { | ||
| callback(null); |
Member
There was a problem hiding this comment.
Let's output a warning here that this usage is not recommended
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Looks good, feel free to add a log and merge
bjohansebas
force-pushed
the
fix-plugin-mode-watching
branch
from
July 29, 2026 02:33
cd76955 to
899744a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is just an improvement. As for the rest, I'm not sure how much it would help or whether you actually want to do it.
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
Note
Low Risk
Small, defensive change to shutdown behavior in plugin mode with new tests; no change to standalone watching teardown.
Overview
Fixes a crash when
close()is called while the middleware is used as a plugin (isPlugin = true). In that mode the host ownscompiler.watch(), socontext.watchingis never set;close()used to throw when it tried to callwatching.close().close()now checks for a missingwatchinginstance, logs a warning pointing callers atcompiler.close(), invokes the callback with no error, and returns without touching the host’s watch session. Plugin-mode tests cover both idle and host-watching cases, with snapshot assertions on the warning text. A patch changeset records the fix.A TODO on
invalidate()notes the samewatchinggap still exists there and is not addressed in this PR.Reviewed by Cursor Bugbot for commit c82442d. Bugbot is set up for automated code reviews on this repo. Configure here.