Skip to content

[dnm] chore: remove Node.js 4, add Node.js 10 - #80

Merged
sokra merged 3 commits into
webpack:masterfrom
DanielRuf:chore/remove-nodejs-4-add-nodejs-10
Jan 4, 2019
Merged

[dnm] chore: remove Node.js 4, add Node.js 10#80
sokra merged 3 commits into
webpack:masterfrom
DanielRuf:chore/remove-nodejs-4-add-nodejs-10

Conversation

@DanielRuf

@DanielRuf DanielRuf commented May 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #79

@alexander-akait
alexander-akait requested review from ooflorent and sokra May 3, 2018 12:39
@DanielRuf

DanielRuf commented May 3, 2018

Copy link
Copy Markdown
Contributor Author

See the following because of the failing Windows build: nodejs/node#20297

@evenstensberg

evenstensberg commented May 3, 2018

Copy link
Copy Markdown
Member

@evilebottnawi should we add v10 anyways?

@alexander-akait

alexander-akait commented May 3, 2018

Copy link
Copy Markdown
Member

Looks we catch node 10.0.0 bug 😆

@alexander-akait

alexander-akait commented May 3, 2018

Copy link
Copy Markdown
Member

@ev1stensberg yep, we need add 10.0.0 in all webpack/webpack-contrib repos

@alexander-akait

alexander-akait commented May 3, 2018

Copy link
Copy Markdown
Member

Blocker nodejs/node#20297. Using webpack and watch mode on nodejs 10.0.0 can't works as expected 😞

@alexander-akait alexander-akait mentioned this pull request May 3, 2018
Closed
@alexander-akait alexander-akait changed the title chore: remove Node.js 4, add Node.js 10 [dnm] chore: remove Node.js 4, add Node.js 10 May 3, 2018
@alexander-akait alexander-akait mentioned this pull request May 3, 2018
Closed
@DanielRuf

DanielRuf commented May 3, 2018

Copy link
Copy Markdown
Contributor Author

webpack and watch mode

The watch mode is used on CI? Shouldn't this not be the case normally?

@alexander-akait

alexander-akait commented May 3, 2018

Copy link
Copy Markdown
Member

@DanielRuf here tests for watch systems

@DanielRuf

DanielRuf commented May 3, 2018

Copy link
Copy Markdown
Contributor Author

@DanielRuf here tests for watch systems

Ah ok, makes definitely sense 😃 Sorry.

@DanielRuf DanielRuf mentioned this pull request May 4, 2018
Merged
@alexander-akait

alexander-akait commented May 10, 2018

Copy link
Copy Markdown
Member

@DanielRuf we need restart CI, node 10.1.0 release

@codecov

codecov Bot commented May 10, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    95.5%   95.5%           
======================================
  Files           3       3           
  Lines         356     356           
  Branches       97      97           
======================================
  Hits          340     340           
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...0ca8fad. Read the comment docs.

@DanielRuf

DanielRuf commented May 10, 2018

Copy link
Copy Markdown
Contributor Author

@DanielRuf we need restart CI, node 10.1.0 release

Seems it is not yet available on Appveyor. Should I ping them?

@DanielRuf DanielRuf mentioned this pull request Jun 8, 2018
Closed
@DanielRuf

DanielRuf commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

See nodejs/node#20738

@alexander-akait

alexander-akait commented Jun 8, 2018

Copy link
Copy Markdown
Member

/cc @ooflorent can you restart CI, looks i don't have access

@ooflorent

ooflorent commented Jun 8, 2018

Copy link
Copy Markdown

I don’t have enough privilege on appveyor. Close/reopen works best.

@ooflorent ooflorent closed this Jun 8, 2018
@ooflorent ooflorent reopened this Jun 8, 2018
@ooflorent ooflorent closed this Jul 6, 2018
@ooflorent ooflorent reopened this Jul 6, 2018
@codecov

codecov Bot commented Sep 18, 2018

Copy link
Copy Markdown

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    95.5%   95.5%           
======================================
  Files           3       3           
  Lines         356     356           
  Branches       97      97           
======================================
  Hits          340     340           
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...0ca8fad. Read the comment docs.

1 similar comment
@codecov

codecov Bot commented Sep 18, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #80   +/-   ##
======================================
  Coverage    95.5%   95.5%           
======================================
  Files           3       3           
  Lines         356     356           
  Branches       97      97           
======================================
  Hits          340     340           
  Misses         16      16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d839e8...0ca8fad. Read the comment docs.

@sokra
sokra merged commit b373c5f into webpack:master Jan 4, 2019
@sokra

sokra commented Jan 4, 2019

Copy link
Copy Markdown
Member

Thanks

@DanielRuf
DanielRuf deleted the chore/remove-nodejs-4-add-nodejs-10 branch March 17, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sokra sokra sokra approved these changes
@evenstensberg evenstensberg evenstensberg approved these changes
+1 more reviewer
@ooflorent ooflorent ooflorent approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DanielRuf @evenstensberg @alexander-akait @ooflorent @sokra