feat: say which kinds of typescript diagnostic to report - #340
Merged
Merged
Conversation
alexander-akait
force-pushed
the
feat/typescript-diagnostic-options
branch
from
September 13, 2026 22:35
c5c818f to
43024b6
Compare
`ignoreDiagnostics` drops what a program answered; `diagnosticOptions` asks it for less, so a check that only wants syntax errors does not pay for the type checking it then throws away. Every kind is reported unless one is turned off, which is the default `fork-ts-checker-webpack-plugin` spells the same way with `semantic` alone. What the config file itself is wrong about is reported whatever is turned off: with the config file misread, nothing below it would be answering the right question. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GzZci4NQeiqwdrVfd7dGXy
alexander-akait
force-pushed
the
feat/typescript-diagnostic-options
branch
from
September 13, 2026 23:37
43024b6 to
2b6e54f
Compare
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignoreDiagnosticsdrops what a program answered;diagnosticOptionsasks it for less, so a check that only wants syntax errors does not pay for the type checking it then throws away. It takessyntactic,semantic,declarationandglobal, and every kind is reported unless you turn one off.What the
tsconfig.jsonitself is wrong about is reported whatever is turned off — with the config file misread, nothing below it would be answering the right question — andbuildreports the whole of what it finds either way, since a solution is built rather than asked kind by kind.Checked against the ecosystem first, as asked.
fork-ts-checker-webpack-pluginis the only other plugin with this, so the option is spelled exactly as it spells it; its default issemanticalone, ours is everything, which is the behaviour this repo already had.vite-plugin-checkerhas nothing of the sort: its only filter isdev.logLevel: ('error' | 'warning')[]per checker, which isreportAshere and already shared across every check. Nothing new was invented.Rebased onto
mainnow that #339 has landed, so this is one commit again. #341 sits on top of it.What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes —
test/typescript/kinds.test.jsover a fixture holding one syntax error and one type error: every kind by default, each of the two turned off on its own, nothing reported with all four off, and a config file's own error reported even then.Does this PR introduce a breaking change?
No — a new option, and nothing is turned off by default.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Documented in
README.mdunder the TypeScript check, and thefork-ts-checker-webpack-pluginmigration row updated.Use of AI
Claude Code read
vite-plugin-checker@0.14.5andfork-ts-checker-webpack-plugin@9.1.0for the option's shape, wrote the change, the tests and this description; I reviewed all of it.🤖 Generated with Claude Code
https://claude.ai/code/session_01GzZci4NQeiqwdrVfd7dGXy