fix(impl): stop dropping words color#253
Merged
Merged
Conversation
gen-quality
|
9bf425e to
49436ef
Compare
Coverage reportCore-dev coverage
|
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 77.8% | 28487 / 36624 |
| Functions | 74.3% | 6349 / 8550 |
| Branches | 50.6% | 22632 / 44725 |
API coverage src/private/mx/{api,impl,utility}/
| Metric | Coverage | Covered / Total |
|---|---|---|
| Lines | 78.5% | 5915 / 7537 |
| Functions | 63.5% | 2006 / 3159 |
| Branches | 47.8% | 5000 / 10457 |
Core HTML report | API HTML report
Commit f7b1d42049ed8196469955cfc51b5da4ecbee7b3.
gen-quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207.
parseWordscallsgetColor()but never setsisColorSpecified, soDirectionWritersilentlydrops the color on write. Mirror the pattern already used by
parseRehearsal,parseSegno, andparseCoda: checkwordEl.color().has_value()and gate both the flag and thegetColorcall.