Skip to content

build: isolate docker volumes per checkout#252

Merged
webern merged 1 commit into
mainfrom
docker-volume-isolation
Jun 28, 2026
Merged

build: isolate docker volumes per checkout#252
webern merged 1 commit into
mainfrom
docker-volume-isolation

Conversation

@webern

@webern webern commented Jun 28, 2026

Copy link
Copy Markdown
Owner

DOCKER_VOLUME was hardcoded to mx-build, so two worktrees building simultaneously would share
a single Docker volume and corrupt each other's build cache. Derive the volume name from an 8-char
hash of $(CURDIR) so each worktree gets an isolated cache. The mx-sdk image stays shared since
the toolchain is the same everywhere.

Uses ?= so the name can be overridden via env. CI is unaffected — it hardcodes mx-build
directly in the workflow YAML, not through the Makefile variable.

@github-actions

Copy link
Copy Markdown

gen-quality gen/

gen-quality: 84.5 / 100   (floor 84.5, +0.0)

  structure     86.5  x0.50   [fn 90.5 / file 82.6]
  cyclomatic    88.4  x0.25
  cognitive     76.6  x0.25

  409 functions across 31 files, 7702 lines (largest file 1044)
  max cc 56  max cognitive 44  max fn loc 152

Worst offenders (top 5 per axis; full lists in score.json):
  cyclomatic gen/xsd/analyze.py:311     report                             56
  cyclomatic gen/plates/build.py:956    _validate_config_against_ir        35
  cyclomatic gen/press/context.py:145   plate_context                      34
  cyclomatic gen/__main__.py:46         _ir                                23
  cyclomatic gen/tests/test_ir.py:102   _check_references                  20
  cognitive  gen/xsd/analyze.py:311     report                             44
  cognitive  gen/ir/resolve.py:119      flat_elements                      40
  cognitive  gen/tests/test_ir.py:102   _check_references                  38
  cognitive  gen/press/context.py:145   plate_context                      37
  cognitive  gen/xsd/analyze.py:207     _sccs                              37
  size       gen/xsd/analyze.py:311     report                             152
  size       gen/press/context.py:145   plate_context                      96
  size       gen/plates/build.py:533    _value_plate                       89
  size       gen/plates/build.py:956    _validate_config_against_ir        89
  size       gen/ir/resolve.py:119      flat_elements                      78

Commit 3d3714da90308b92a05ebdabbded012b7f4309aa.

@webern webern force-pushed the docker-volume-isolation branch from 9bf425e to 49436ef Compare June 28, 2026 16:04
@github-actions

Copy link
Copy Markdown

Coverage report

Core-dev coverage src/private/mx/core/

Metric Coverage Covered / Total
Lines 77.8% 28487 / 36624
Functions 74.3% 6349 / 8550
Branches 50.6% 22632 / 44725

API coverage src/private/mx/{api,impl,utility}/

Metric Coverage Covered / Total
Lines 78.5% 5913 / 7535
Functions 63.5% 2006 / 3159
Branches 47.8% 4998 / 10455

Core HTML report | API HTML report

Commit dad81c1868fd7b3f906072b7c544702a0ba2aef2.

@github-actions

Copy link
Copy Markdown

gen-quality gen/

gen-quality: 84.5 / 100   (floor 84.5, +0.0)

  structure     86.5  x0.50   [fn 90.5 / file 82.6]
  cyclomatic    88.4  x0.25
  cognitive     76.6  x0.25

  409 functions across 31 files, 7702 lines (largest file 1044)
  max cc 56  max cognitive 44  max fn loc 152

Worst offenders (top 5 per axis; full lists in score.json):
  cyclomatic gen/xsd/analyze.py:311     report                             56
  cyclomatic gen/plates/build.py:956    _validate_config_against_ir        35
  cyclomatic gen/press/context.py:145   plate_context                      34
  cyclomatic gen/__main__.py:46         _ir                                23
  cyclomatic gen/tests/test_ir.py:102   _check_references                  20
  cognitive  gen/xsd/analyze.py:311     report                             44
  cognitive  gen/ir/resolve.py:119      flat_elements                      40
  cognitive  gen/tests/test_ir.py:102   _check_references                  38
  cognitive  gen/press/context.py:145   plate_context                      37
  cognitive  gen/xsd/analyze.py:207     _sccs                              37
  size       gen/xsd/analyze.py:311     report                             152
  size       gen/press/context.py:145   plate_context                      96
  size       gen/plates/build.py:533    _value_plate                       89
  size       gen/plates/build.py:956    _validate_config_against_ir        89
  size       gen/ir/resolve.py:119      flat_elements                      78

Commit dad81c1868fd7b3f906072b7c544702a0ba2aef2.

@webern webern changed the title isolate Docker build volumes per worktree build: isolate docker volumes per checkout Jun 28, 2026
@webern webern merged commit c313366 into main Jun 28, 2026
7 checks passed
@webern webern deleted the docker-volume-isolation branch June 28, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant