Tighten text-click with ambiguity detection and auto-fallback - #5
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…etection, align selector lists - Resolve merge conflicts in manifest.json and firefox settings.html (keep v1.7.0) - Change text-click default from strict exact-only to exact→prefix→contains cascade, with ambiguity error (>1 match) enforced at each level - Update CLICKING system prompt in both Chrome and Firefox to document new behavior - Add `label` to clickable selector lists to match INTERACTIVE_SELECTORS Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
esokullu
changed the title
esokullu
added a commit
that referenced
this pull request
Jun 22, 2026
feat: autocomplete slash commands
esokullu
added a commit
that referenced
this pull request
Jun 23, 2026
- drainQueuedContextMenuPrompts: replace shift()+continue with findIndex+splice so prompts for non-active tabs stay in the queue instead of being permanently discarded (finding #1) - tabs.onRemoved / webNavigation.onCommitted: route cleanup through getContextMenuPromptStore() so local-storage fallback is cleared too; add navigation listener to invalidate stale prompts on page change (findings #2, #3) - runContextMenuPrompt: move clear_context_menu_prompt dispatch to after sendMessage() so storage isn't wiped before text is captured (finding #4) - Extract context-menu-storage.js and context-menu-prompts.js as shared factory modules (identical in Chrome/Firefox); remove ~160 lines of duplicated code from background.js and sidepanel.js (findings #5, #6) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
click({text: "Save"})now returns an error with candidate list when multiple elements match, instead of silently clicking the first onetextMatch: "contains"textMatchparameter: New optional param (exact,prefix,contains) for explicit control when neededlabelto text-click selector lists to matchINTERACTIVE_SELECTORS(fixes inconsistency whereget_interactive_elementsshowed labels as clickable butclick({text})couldn't find them)Test plan
npm test— all 31 tests pass🤖 Generated with Claude Code