Skip to content

Fix broken parameter passing when calling recognizeUsingWebSocket - #895

Merged
germanattanasio merged 1 commit into
developfrom
stt-web-socket-fix
Mar 14, 2018
Merged

Fix broken parameter passing when calling recognizeUsingWebSocket#895
germanattanasio merged 1 commit into
developfrom
stt-web-socket-fix

Conversation

@lpatino10

@lpatino10 lpatino10 commented Mar 14, 2018

Copy link
Copy Markdown
Contributor

Currently, when setting the JSON body for a recognizeUsingWebSocket() call, the JSON keys are left as camelCase, so some parameters are being unrecognized by the service (ex: interimResults).

This PR ensures that the JSON body is properly formatted.

@codecov-io

codecov-io commented Mar 14, 2018

Copy link
Copy Markdown

Codecov Report

Merging #895 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #895      +/-   ##
=============================================
- Coverage      64.19%   64.18%   -0.01%     
  Complexity      2072     2072              
=============================================
  Files            454      454              
  Lines          10651    10654       +3     
  Branches         631      631              
=============================================
+ Hits            6837     6838       +1     
- Misses          3490     3493       +3     
+ Partials         324      323       -1
Impacted Files Coverage Δ Complexity Δ
...xt/v1/websocket/SpeechToTextWebSocketListener.java 73.61% <100%> (-3.21%) 13 <1> (-1)
...ch_to_text/v1/websocket/BaseRecognizeCallback.java 50% <0%> (+10%) 5% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98277f6...1c3aeee. Read the comment docs.

@germanattanasio
germanattanasio merged commit fda6404 into develop Mar 14, 2018
@germanattanasio

Copy link
Copy Markdown
Contributor

Let's release this as a patch release tomorrow morning.

@germanattanasio
germanattanasio deleted the stt-web-socket-fix branch March 14, 2018 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants