Skip to content

Check text files out as LF everywhere - #8

Merged
walhalabi-code merged 1 commit into
mainfrom
fix/line-endings
Aug 30, 2026
Merged

walhalabi-code merged 1 commit into
mainfrom
fix/line-endings

Conversation

@walhalabi-code

Copy link
Copy Markdown
Owner

The suite fails on a fresh clone on Windows, and has since the repository was created. Git's core.autocrlf is on by default there, so checkout rewrites text files to CRLF; test/ai.test.ts asserts body.startsWith('---\n') on a generated skill file, which is false once the bytes on disk are ---\r\n.

CI never saw it because Linux runners check out LF, and the maintainer's working copy predates any checkout so it still holds the original LF. Only someone cloning fresh on Windows hits it, which is to say a new contributor on their first npm test.

The stored blobs are already LF, so this changes checkout behaviour only and no file content moves.

Found while investigating why Dependabot PR #5 failed. That turned out to be unrelated: its lockfile is out of sync with its package.json, so every job dies at npm ci before a test runs. jest 30 itself is fine - 332 of 334 pass on it, and the single failure is this line-ending bug, which reproduces identically on jest 29.

The suite fails on a fresh clone on Windows, and has since the repository was
created. Git's core.autocrlf is on by default there, so checkout rewrites text
files to CRLF; test/ai.test.ts asserts body.startsWith('---\n') on a generated
skill file, which is false once the bytes on disk are ---\r\n.

CI never saw it because Linux runners check out LF, and the maintainer's working
copy predates any checkout so it still holds the original LF. Only someone
cloning fresh on Windows hits it, which is to say a new contributor on their
first npm test.

The stored blobs are already LF, so this changes checkout behaviour only and no
file content moves.

Found while investigating why Dependabot PR #5 failed. That turned out to be
unrelated: its lockfile is out of sync with its package.json, so every job dies
at npm ci before a test runs. jest 30 itself is fine - 332 of 334 pass on it,
and the single failure is this line-ending bug, which reproduces identically on
jest 29.
@walhalabi-code
walhalabi-code merged commit ba7cae7 into main Aug 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant