Repository navigation
Check text files out as LF everywhere - #8
Merged
Merged
Conversation
The suite fails on a fresh clone on Windows, and has since the repository was
created. Git's core.autocrlf is on by default there, so checkout rewrites text
files to CRLF; test/ai.test.ts asserts body.startsWith('---\n') on a generated
skill file, which is false once the bytes on disk are ---\r\n.
CI never saw it because Linux runners check out LF, and the maintainer's working
copy predates any checkout so it still holds the original LF. Only someone
cloning fresh on Windows hits it, which is to say a new contributor on their
first npm test.
The stored blobs are already LF, so this changes checkout behaviour only and no
file content moves.
Found while investigating why Dependabot PR #5 failed. That turned out to be
unrelated: its lockfile is out of sync with its package.json, so every job dies
at npm ci before a test runs. jest 30 itself is fine - 332 of 334 pass on it,
and the single failure is this line-ending bug, which reproduces identically on
jest 29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The suite fails on a fresh clone on Windows, and has since the repository was created. Git's core.autocrlf is on by default there, so checkout rewrites text files to CRLF; test/ai.test.ts asserts body.startsWith('---\n') on a generated skill file, which is false once the bytes on disk are ---\r\n.
CI never saw it because Linux runners check out LF, and the maintainer's working copy predates any checkout so it still holds the original LF. Only someone cloning fresh on Windows hits it, which is to say a new contributor on their first npm test.
The stored blobs are already LF, so this changes checkout behaviour only and no file content moves.
Found while investigating why Dependabot PR #5 failed. That turned out to be unrelated: its lockfile is out of sync with its package.json, so every job dies at npm ci before a test runs. jest 30 itself is fine - 332 of 334 pass on it, and the single failure is this line-ending bug, which reproduces identically on jest 29.