Conversation
✅ Deploy Preview for wai-aria-practices2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was
linked to
issues
Jun 20, 2022
howard-e
approved these changes
Jun 22, 2022
|
@jongund we are in the process of getting ready for a coordinated deploy with WAI on the morning of 6/24. We will review this PR again and merge it in. Please refrain from making any other commits so I can make sure all is in good order for the deploy. |
howard-e
reviewed
Jun 23, 2022
Contributor
|
@richnoah Idon't concur with latest changes by Jon; I need to fix the license/copyright to be what is appropriate based on agreement with skipto. |
mcking65
approved these changes
Jun 23, 2022
Contributor
mcking65
left a comment
There was a problem hiding this comment.
Thank you all; this is good to ship now. I will merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the code base from using JumpTo.js to SkipTo.js.
The 4.2 version of SkipTo.js has been updated to fix the following issues: