Skip to content

replace jumpto.js with skipto.js version 4.2 #131

Merged
mcking65 merged 24 commits intomainfrom
dev/skipto
Jun 23, 2022
Merged

replace jumpto.js with skipto.js version 4.2 #131
mcking65 merged 24 commits intomainfrom
dev/skipto

Conversation

@jongund
Copy link
Copy Markdown
Contributor

@jongund jongund commented Jun 16, 2022

This pull request changes the code base from using JumpTo.js to SkipTo.js.

The 4.2 version of SkipTo.js has been updated to fix the following issues:

  1. Removing copyright code concerns by using the skipto.js script instead of the jumpto.js script, see SkipTo copyright statement in code.
  2. Selection of main landmark option on the home page, by insuring focus moves to a visible element.
  3. The Skip To menu button labeling issue (e..g. "opton" is now pronounced instead of "command" on macOS).
  4. The skipto menu of options will now scroll if the number of items exceeds the size of the window to display them all.

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 16, 2022

Deploy Preview for wai-aria-practices2 ready!

Name Link
🔨 Latest commit f83e9ef
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria-practices2/deploys/62b4b82df4f06a0009bf396c
😎 Deploy Preview https://deploy-preview-131--wai-aria-practices2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@richnoah
Copy link
Copy Markdown

@jongund we are in the process of getting ready for a coordinated deploy with WAI on the morning of 6/24. We will review this PR again and merge it in. Please refrain from making any other commits so I can make sure all is in good order for the deploy.

@mcking65
Copy link
Copy Markdown
Contributor

@richnoah Idon't concur with latest changes by Jon; I need to fix the license/copyright to be what is appropriate based on agreement with skipto.

Copy link
Copy Markdown
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all; this is good to ship now. I will merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JumpTo Main does not work on Home Page JumpTo: can't scroll to bottom of menu if not fully visible in viewport JumpTo menu label incorrect on Mac

4 participants