Repository navigation
Carry partial RowFn validity with MaskValues - #9534
Merged
Merged
Conversation
Merging this PR will not alter performance
|
connortsui20
force-pushed
the
ct/row-fn-validity-invariants
branch
from
August 21, 2026 13:01
9600ed9 to
d97927d
Compare
connortsui20
had a problem deploying
to
duckdb-build
August 21, 2026 13:02 — with 
GitHub Actions
Error
GitHub Actions
Error
connortsui20
had a problem deploying
to
duckdb-build
August 21, 2026 13:02 — with
GitHub Actions
Error
GitHub Actions
Error
connortsui20
had a problem deploying
to
duckdb-build
August 21, 2026 13:02 — with
GitHub Actions
Error
GitHub Actions
Error
connortsui20
marked this pull request as ready for review
August 21, 2026 13:02
connortsui20
commented
Aug 21, 2026
Comment on lines
+65
to
74
| // Do not resolve array-backed validity for the uncommon all-valid or all-null cases here. | ||
| // That can execute and scan the full mask; each policy resolves it only when necessary. | ||
| if self.validity.definitely_no_nulls() { | ||
| return self.execute_dense(kernel, ctx); | ||
| } | ||
|
|
||
| match self.policy { | ||
| RowPolicy::Dense => self.execute_dense(kernel, ctx), | ||
| RowPolicy::ValidOnly => self.execute_valid_only(kernel, try_valid_rows, ctx), | ||
| } |
Member
Author
There was a problem hiding this comment.
im realizing it is better to just match on the self.policy first and then only check for definitely_no_nulls in the valid-only case
joseph-isaacs
approved these changes
Aug 21, 2026
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/row-fn-validity-invariants
branch
from
August 21, 2026 16:28
6e098c2 to
ccdccb9
Compare
connortsui20
enabled auto-merge (squash)
August 21, 2026 16:28
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Row batch execution resolves validity once, but the valid-row executors repeat the check that the materialized mask is partial. Array-backed validity stays lazy on optimistic paths because resolving it can execute and linearly scan the full mask for the uncommon all-valid and all-null cases.
Changes
Matches the materialized
Maskonce and passesMaskValuesthrough valid-row visitors, owned execution, and sink execution. Marks the all-null dense path as unreachable and documents the cost boundary onValidity::execute_mask.