Repository navigation
Add built-in stats rewrite rules - #7935
Merged
Merged
Conversation
gatesn
force-pushed
the
ngates/stats-7707/min-max-aggregate-fns
branch
from
May 14, 2026 22:32
988447b to
b22ebfe
Compare
gatesn
force-pushed
the
ngates/stats-7707/built-in-rewrite-rules
branch
from
May 14, 2026 22:34
dfce840 to
b08d3d5
Compare
31 of 42 tasks
gatesn
force-pushed
the
ngates/stats-7707/min-max-aggregate-fns
branch
from
May 14, 2026 23:02
b22ebfe to
c1e72a3
Compare
gatesn
force-pushed
the
ngates/stats-7707/built-in-rewrite-rules
branch
from
May 14, 2026 23:02
b08d3d5 to
410ff05
Compare
Merging this PR will improve performance by 19.86%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
225.1 µs | 187.8 µs | +19.86% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ngates/stats-7707/built-in-rewrite-rules (cf1c23b) with develop (a8fb30e)
gatesn
marked this pull request as ready for review
May 15, 2026 00:13
gatesn
force-pushed
the
ngates/stats-7707/built-in-rewrite-rules
branch
2 times, most recently
from
May 15, 2026 03:51
5cdafee to
9700eec
Compare
gatesn
force-pushed
the
ngates/stats-7707/min-max-aggregate-fns
branch
from
May 15, 2026 03:51
c1e72a3 to
4f74bb3
Compare
gatesn
force-pushed
the
ngates/stats-7707/built-in-rewrite-rules
branch
from
May 15, 2026 09:16
9700eec to
bc790ff
Compare
gatesn
force-pushed
the
ngates/stats-7707/min-max-aggregate-fns
branch
from
May 15, 2026 09:16
4f74bb3 to
78f93f1
Compare
gatesn
force-pushed
the
ngates/stats-7707/built-in-rewrite-rules
branch
from
May 15, 2026 09:23
bc790ff to
ad61595
Compare
gatesn
force-pushed
the
ngates/stats-7707/min-max-aggregate-fns
branch
from
May 15, 2026 09:23
78f93f1 to
aa967fc
Compare
robert3005
approved these changes
May 15, 2026
gatesn
force-pushed
the
ngates/stats-7707/min-max-aggregate-fns
branch
from
May 17, 2026 15:51
aa967fc to
d963a44
Compare
gatesn
changed the base branch from
ngates/stats-7707/min-max-aggregate-fns
to
ngates/stats-7707/typed-stats-rewrite-api
May 17, 2026 16:41
gatesn
force-pushed
the
ngates/stats-7707/built-in-rewrite-rules
branch
from
May 19, 2026 20:46
ad61595 to
863ff76
Compare
gatesn
force-pushed
the
ngates/stats-7707/typed-stats-rewrite-api
branch
from
May 19, 2026 20:46
dd555d9 to
5c04e3d
Compare
Base automatically changed from
ngates/stats-7707/typed-stats-rewrite-api
to
ngates/stats-7707/min-max-aggregate-fns
May 19, 2026 20:46
Base automatically changed from
ngates/stats-7707/min-max-aggregate-fns
to
ngates/stats-7707/typed-stats-rewrite-api
May 19, 2026 20:49
gatesn
force-pushed
the
ngates/stats-7707/typed-stats-rewrite-api
branch
from
May 19, 2026 20:49
cbc5046 to
5c04e3d
Compare
gatesn
marked this pull request as draft
May 19, 2026 20:50
gatesn
changed the base branch from
ngates/stats-7707/typed-stats-rewrite-api
to
ngates/stats-7707/min-max-aggregate-fns
May 19, 2026 20:50
gatesn
marked this pull request as ready for review
May 19, 2026 21:23
Base automatically changed from
ngates/stats-7707/min-max-aggregate-fns
to
develop
May 21, 2026 14:39
Signed-off-by: Nicholas Gates <nick@nickgates.com>
gatesn
force-pushed
the
ngates/stats-7707/built-in-rewrite-rules
branch
from
May 21, 2026 14:54
863ff76 to
cf1c23b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatFn::new_expr(...)all_nullandall_non_nullnull_count/row_count()rewrite rules so current stored stats continue to workTests
cargo +nightly fmt --allcargo test -p vortex-array stats::rewrite::builtins::tests::rewrites_nullcargo test -p vortex-array stats::rewritecargo clippy --all-targets --all-features