Repository navigation
Conversation
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
…ked.v2 is allowed Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
added this pull request to stack #10243
October 2, 2026 22:11
Merging this PR will not alter performance
|
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
mhk197
marked this pull request as ready for review
October 2, 2026 22:46
This was referenced Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking Issue: #10167
Stacked on #10244; this PR targets
mk/bitpacked-v2-wire.Summary
BitPackingSchemepacks each 1024-element block at its own bit width when the compressor's allowed serialized IDs includefastlanes.bitpacked.v2, followingFoRScheme(#10136). Default writes are unchanged: the core edition allows onlyfastlanes.bitpacked, sorefinekeeps v1.BitPackingSchemeBitPackingSchemegains v1 and v2 modes withv1()andv2()constructors, andDefaultis v1. The session registersBITPACKING_V1.refinereturns v2 whenfastlanes.bitpacked.v2is allowed, and v1 otherwise.produced_encodings: v1 declaresfastlanes.bitpacked; v2 declaresfastlanes.bitpacked.v2.FoRSchemev2 always encodes per-chunk references. It chooses every block's width withbitpack_to_best_bit_widths(BlockedBitPacked: encode blocked bitwidths #10203), even when every block chooses the same width, and compresses the block offsets as child 0 withcompress_child. Patches are handled as in v1: compressed in place, or moved intoPatchedunder experimental patches.FoRSchemestill bit-packs its encoded child withBITPACKING_V1, so FoR arrays keep a global width for now.CUDA
The CUDA preset excludes
fastlanes.bitpacked.v2, as it doesfastlanes.for.v2. CUDA decoding returns an error for per-block bit widths.Testing
refinepicks v2 exactly when the v2 ID is allowed, from either mode.tests/bitpacking_config.rs: with only BitPacking and every ID allowed, both blocks needing 1 to 8 bits and uniform 7-bit blocks serialize as v2, and nullable values round trip. The core edition never writes v2, and the CUDA preset writes v1.Follow-ups
FoRSchemewould bit-pack with v2 whenfastlanes.bitpacked.v2is allowed, so per-chunk references and per-block widths combine.FoRSchemeto per-chunk references whenfastlanes.for.v2is allowed #10136.