Repository navigation
Define which aggregate results survive representation changes - #10232
Closed
connortsui20 wants to merge 1 commit into
Closed
connortsui20 wants to merge 1 commit into
connortsui20 wants to merge 1 commit into
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
added this pull request to stack #10229
October 2, 2026 19:55
This was referenced Oct 2, 2026
connortsui20
removed this pull request from stack #10229
October 5, 2026 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #10235, which groups this change with the related statistics work. The original commits and branch are preserved.
Original PR description
Tracking Issue: #10177
Summary
Rebuilding an array can preserve its logical values while changing its storage. Cached extrema can remain useful, while
UncompressedSizeInBytescan change because it counts retained backing buffers. Generic aggregate results therefore need an explicit reuse contract before replacing the fixed statistics cache.Changes
Let each aggregate opt into result reuse across representations of the same logical input, including its validity, order, dtype, and bound options. Custom aggregates default to their physical input. Logical builtins opt in, and combined aggregates require both children to opt in. This permits reuse of an existing floating-point answer without promising bit-identical fresh computation through another encoding.
The cache migration will use this contract when transferring results.
Stack
Migration stack #10229, in review order: #10226 → #10227 → #10232 → #10235 → #10236 → #10252 → #10253 → #10257 → #10258 → #10259 → #10260 → #10261. Independent fixes: file Sum overflow #10228 and empty Constant aggregate states #10254.