refactor(fspy-shm): adopt fspy_nostd on Windows - #666
Merged
Conversation
Move Windows file handles, sparse-file operations, and mapped views behind direct no-std Win32 wrappers. Keep the existing fspy_shm public API while removing its production memmap2 and direct windows-sys use. Co-authored-by: GPT-5 Codex <codex@openai.com>
fspy benchmarklinuxmacoswindows |
Mirror the std remove_file fallback to FileDispositionInfoEx when DeleteFileW is denied, so dropping a shared-memory keeper removes the pathname while existing handles remain usable. Co-authored-by: GPT-5 Codex <codex@openai.com>
Replace the policy-heavy map_file helper with one-to-one CreateFileMappingW and MapViewOfFile wrappers. Keep MappingView as the owned RAII view and move shared-memory policy into fspy_shm. Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Co-authored-by: GPT-5 Codex <codex@openai.com>
Address review findings on the no-std adoption:
- Convert long backing paths to verbatim form in copy_path, matching the
std conversion the raw CreateFileW/DeleteFileW calls no longer get.
- Give every Mapping a duplicated file handle closed only after its view
unmaps, so the DELETE_ON_CLOSE fallback removal fires once the last
view is gone on volumes without POSIX delete.
- Open reparse points rather than their targets when creating the
backing file and in the delete-on-close fallback, as std does.
- Add the checked WideCStr::from_units_with_nul constructor and use it
instead of a safe wrapper around the unchecked one.
- Export fspy_nostd::{bool_result, last_error} and drop the duplicate in
fspy_shm.
- Add BorrowedHandle::try_clone_to_owned and reconcile the handle
sentinel docs with their constructor contracts.
- Model PageProtection as an enum, drop create_file_mapping's unused
name parameter, and omit the CreateAlways/OpenAlways dispositions
whose already-existed signal create_file does not surface.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Assume NTFS on Windows 10 1607+, where POSIX delete unlinks a name even while views of the file remain mapped: - remove_file now opens the backing file and sets FileDispositionInfoEx with POSIX semantics directly, instead of trying DeleteFileW first. - Drop the DELETE_ON_CLOSE fallback, and with it the duplicated file handle each Mapping held only to make that fallback fire after the last view unmapped. - Remove the now-unused fspy_nostd delete_file wrapper, FileOptions::DELETE_ON_CLOSE, BorrowedHandle::try_clone_to_owned, and the Win32_System_Threading feature. - Document the platform floor on ShmKeeper. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replace the hand-rolled `\\?\` prefix logic with omnipath's to_verbatim, which also normalizes through GetFullPathNameW first and covers the device-path and drive-relative shapes the local version left alone. omnipath is dependency-free and maintained by the author of std's own Windows path handling. The copy_path unit tests are kept and now pin the integration's behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Windows preload opens and maps shared memory before main and under the loader lock, where Rust std lazy initialization is not a dependable foundation. This moves the Windows implementation onto no-std Win32 calls while preserving the existing fspy_shm API.
It is the Windows counterpart to #664: fspy_nostd provides small safe wrappers where it can enforce path, handle, or mapping ownership. fspy_shm calls DeviceIoControl and SetFileInformationByHandle directly because their buffer contracts and flags are specific to its sparse-file, sizing, and removal policy. The outer OsStr and io::Error conversion remains for the later public API migration.