Repository navigation
fix(upgrade): serialize installation changes and keep existing version directories - #3412
Conversation
A failed upgrade removed its target version directory even when that directory existed before the upgrade started. Installing a kept version or the rollback target again, then failing during dependency installation, deleted that version. `vp upgrade --rollback` then failed because `.previous-version` pointed to a missing directory. Create the version directory with `create_dir`, record whether this run created it, and remove it on failure only in that case. `vp upgrade` and the legacy `vp-setup` path share the helper.
Concurrent `vp upgrade` runs shared the target version directory, the `current.new` temporary link, `.previous-version`, and old-version cleanup without coordination. Two terminals upgrading to the same version could overwrite the rollback record with the new version, and a run that failed during the link swap could remove the directory the other run had just activated. Add a blocking file lock at `<DATA>/.install.lock`. `vp upgrade` takes it after downloading and verifying the payload and holds it through cleanup. After the wait it reads `current` again and stops when another run already activated the target version. `vp upgrade --rollback` takes the same lock. The child that `refresh_shims` starts runs setup in place and does not take the lock, so the parent cannot deadlock on it.
A standalone install from `install.sh` or `install.ps1` deploys the downloaded binary through self-setup, which changes `current`, `.previous-version`, and old versions like `vp upgrade`. The legacy `vp-setup` path does the same. Neither path took a lock, so either one could race an upgrade or another installation. Take the installation lock in the self-setup deploy path and around the legacy activation. In-place self-setup does not take it because `vp upgrade` starts that child while holding the lock. The unowned-directory implode snapshot now lists `.install.lock` with the other preserved Vite+ files.
Add two global snapshot cases next to the existing rollback case. `command_upgrade_rollback_deployed` deploys two versions, removes the setup marker from the rollback target, and rolls back. The rollback holds the installation lock while the shim refresh runs in-place setup for that target, so a lock in the in-place path makes the step time out. It then checks `.previous-version` and the recreated marker. `command_upgrade_failed_reinstall_keeps_existing_version` makes extraction fail for an existing `0.3.1` directory and checks that the directory survives. Like `command_upgrade_parent_workspace`, it downloads the released 0.3.1 payload, because the upgrade verifies a published package before it touches the version directory.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36f7a8e2c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The failed reinstall case downloaded the published 0.3.1 metadata and native tarball from npm. No shared recording covered those packages, so an npm outage would fail the snapshot with a network error before it reached the directory check. Serve a 999.0.1 payload from the fixture's `mock-manifest.json` and `tarballs/` instead. The metadata carries provenance and the tarball's real integrity, so the upgrade passes verification and fails at the intended `bin` path. The run records only fixture requests.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df1d9065b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
After the installation lock, `vp upgrade` stopped as up to date whenever `current` named the target version. `read_current_version` reads only the link name, so an older CLI running `vp upgrade <version>` against a `current` link whose binary or directory was missing reported success and left the installation broken. Before the lock change, that command installed the version again. Skip the install only when `current/bin/vp` also exists, as the legacy installer already does. `command_upgrade_repairs_broken_active_version` removes the active binary and upgrades to the same version. The fixture payload has no binary, so the extraction error shows that the upgrade ran instead of returning early.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
# Conflicts: # crates/vp_global_cli/src/commands/upgrade/mod.rs # crates/vp_global_cli/src/self_setup.rs
fengmk2
left a comment
There was a problem hiding this comment.
I’ll merge it after verifying it on Windows.
|
I will take over and make some simplify adjustments. |
It's become much simpler than what I did 🫢 |
Preview binary sizes (
|
| Binary | Latest release | Preview | Change |
|---|---|---|---|
vp (macOS ARM64) |
5.46 MiB | 5.46 MiB | +32 B (+0.00%) |
| NAPI (macOS ARM64) | 43.39 MiB | 43.39 MiB | 0 B (0.00%) |
vp (macOS x64) |
6.92 MiB | 6.92 MiB | +4.03 KiB (+0.06%) |
| NAPI (macOS x64) | 48.76 MiB | 48.76 MiB | 0 B (0.00%) |
vp (Linux ARM64 GNU) |
6.90 MiB | 6.91 MiB | +8.05 KiB (+0.11%) |
| NAPI (Linux ARM64 GNU) | 32.68 MiB | 32.68 MiB | 0 B (0.00%) |
vp (Linux ARM64 musl) |
6.97 MiB | 6.98 MiB | +7.58 KiB (+0.11%) |
| NAPI (Linux ARM64 musl) | 31.89 MiB | 31.89 MiB | 0 B (0.00%) |
vp (Linux x64 GNU) |
8.33 MiB | 8.35 MiB | +16.05 KiB (+0.19%) |
| NAPI (Linux x64 GNU) | 36.69 MiB | 36.69 MiB | 0 B (0.00%) |
vp (Linux x64 musl) |
8.41 MiB | 8.42 MiB | +4.70 KiB (+0.05%) |
| NAPI (Linux x64 musl) | 35.90 MiB | 35.90 MiB | 0 B (0.00%) |
vp (Windows x64) |
6.19 MiB | 6.20 MiB | +5.00 KiB (+0.08%) |
| NAPI (Windows x64) | 32.45 MiB | 32.45 MiB | 0 B (0.00%) |
| Trampoline (Windows x64) | 13.00 KiB | 13.00 KiB | 0 B (0.00%) |
| Installer (Windows x64) | 4.69 MiB | 4.69 MiB | +4.00 KiB (+0.08%) |
vp (Windows ARM64) |
5.42 MiB | 5.42 MiB | +5.00 KiB (+0.09%) |
| NAPI (Windows ARM64) | 28.66 MiB | 28.66 MiB | 0 B (0.00%) |
| Trampoline (Windows ARM64) | 13.00 KiB | 13.00 KiB | 0 B (0.00%) |
| Installer (Windows ARM64) | 3.86 MiB | 3.86 MiB | +4.00 KiB (+0.10%) |
gzip -9 sizes
| Binary | Latest release | Preview | Change |
|---|---|---|---|
vp (macOS ARM64) |
3.25 MiB | 3.25 MiB | +3.19 KiB (+0.10%) |
| NAPI (macOS ARM64) | 18.85 MiB | 18.85 MiB | +1.45 KiB (+0.01%) |
vp (macOS x64) |
3.43 MiB | 3.43 MiB | +4.20 KiB (+0.12%) |
| NAPI (macOS x64) | 20.12 MiB | 20.12 MiB | +2.54 KiB (+0.01%) |
vp (Linux ARM64 GNU) |
3.74 MiB | 3.75 MiB | +4.62 KiB (+0.12%) |
| NAPI (Linux ARM64 GNU) | 13.93 MiB | 13.93 MiB | -49 B (-0.00%) |
vp (Linux ARM64 musl) |
3.77 MiB | 3.77 MiB | +2.08 KiB (+0.05%) |
| NAPI (Linux ARM64 musl) | 13.64 MiB | 13.63 MiB | -4.08 KiB (-0.03%) |
vp (Linux x64 GNU) |
3.81 MiB | 3.82 MiB | +3.27 KiB (+0.08%) |
| NAPI (Linux x64 GNU) | 14.65 MiB | 14.65 MiB | +374 B (+0.00%) |
vp (Linux x64 musl) |
3.84 MiB | 3.84 MiB | +3.99 KiB (+0.10%) |
| NAPI (Linux x64 musl) | 14.33 MiB | 14.33 MiB | -2.44 KiB (-0.02%) |
vp (Windows x64) |
2.86 MiB | 2.87 MiB | +3.83 KiB (+0.13%) |
| NAPI (Windows x64) | 13.31 MiB | 13.31 MiB | -319 B (-0.00%) |
| Trampoline (Windows x64) | 7.14 KiB | 7.14 KiB | -1 B (-0.01%) |
| Installer (Windows x64) | 2.25 MiB | 2.25 MiB | +1.91 KiB (+0.08%) |
vp (Windows ARM64) |
2.73 MiB | 2.74 MiB | +2.08 KiB (+0.07%) |
| NAPI (Windows ARM64) | 12.62 MiB | 12.62 MiB | -51 B (-0.00%) |
| Trampoline (Windows ARM64) | 6.93 KiB | 6.92 KiB | -2 B (-0.03%) |
| Installer (Windows ARM64) | 2.14 MiB | 2.14 MiB | +2.48 KiB (+0.11%) |
Raw sizes are uncompressed file sizes. gzip sizes recompress each binary at level 9; they are not package or download archive sizes.
The baseline uses published release files, including NAPI packages from npm at the same version. Build versions and toolchains can affect the difference.
Registry bridge build (
|
| Package | Version |
|---|---|
vite-plus |
0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826 |
@voidzero-dev/vite-plus-core |
0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826 |
create-vite-plus |
0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826 |
Install the Vite+ CLI built from this commit, then migrate a project:
# macOS / Linux
curl -fsSL https://raw.githubusercontent.com/jong-kyung/vite-plus/b808fa85316443c28dc075bf6365b875ba00d826/packages/cli/install.sh | VP_PR_VERSION=3412 VP_LEGACY_INSTALLER_URL=https://raw.githubusercontent.com/jong-kyung/vite-plus/b808fa85316443c28dc075bf6365b875ba00d826/packages/cli/install-legacy.sh bash# Windows (PowerShell)
$env:VP_PR_VERSION="3412"; $env:VP_LEGACY_INSTALLER_URL="https://raw.githubusercontent.com/jong-kyung/vite-plus/b808fa85316443c28dc075bf6365b875ba00d826/packages/cli/install-legacy.ps1"; irm https://raw.githubusercontent.com/jong-kyung/vite-plus/b808fa85316443c28dc075bf6365b875ba00d826/packages/cli/install.ps1 | iexOr install with Homebrew (macOS / glibc Linux):
These commands use the formula and binary from this published commit. Replace brew install with brew reinstall if the tap package is already installed.
If Homebrew Core’s vite-plus is installed, run brew uninstall vite-plus first. This keeps your user data; do not run vp implode to switch installations.
(
set -eu
export HOMEBREW_NO_AUTO_UPDATE=1
export HOMEBREW_VP_PR_VERSION=b808fa85316443c28dc075bf6365b875ba00d826
brew tap voidzero-dev/vite-plus https://github.com/voidzero-dev/vite-plus
preview_tap="$(brew --repository voidzero-dev/vite-plus)"
git -C "$preview_tap" fetch --depth=1 https://github.com/jong-kyung/vite-plus.git "$HOMEBREW_VP_PR_VERSION"
git -C "$preview_tap" switch --detach "$HOMEBREW_VP_PR_VERSION"
brew install voidzero-dev/vite-plus/vp
brew test voidzero-dev/vite-plus/vp
"$(brew --prefix)/bin/vp"
)The tap stays at the tested commit. Return it to main after testing:
git -C "$(brew --repository voidzero-dev/vite-plus)" switch mainOr download the standalone Windows installer built from this commit:
| Architecture | Installer |
|---|---|
| x64 | vp-setup-x86_64-pc-windows-msvc.exe |
| Arm64 | vp-setup-aarch64-pc-windows-msvc.exe |
GitHub requires you to sign in and downloads each installer as a ZIP artifact. Extract vp-setup.exe, then run it against this preview build:
.\vp-setup.exe --version "0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826" --registry "https://registry-bridge.viteplus.dev/"After installing, upgrade the current project's vite-plus to this test build with:
vp migrateOr create a new project from this commit without installing the CLI:
export npm_config_registry=https://registry-bridge.viteplus.dev/ pnpm_config_registry=https://registry-bridge.viteplus.dev/
pnpm create vite-plus@0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826 # or: npm create vite-plus@0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826$env:npm_config_registry="https://registry-bridge.viteplus.dev/"; $env:pnpm_config_registry="https://registry-bridge.viteplus.dev/"
pnpm create vite-plus@0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826 # or: npm create vite-plus@0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826pnpm 11+ reads pnpm_config_registry, npm and older pnpm read npm_config_registry. The new project pins this build, so keep the registry set for later installs, or configure it as below.
Or point your package manager at the bridge registry https://registry-bridge.viteplus.dev/:
| Package manager | Registry config |
|---|---|
| npm / pnpm / Bun | .npmrc: registry=https://registry-bridge.viteplus.dev/ |
| Yarn (v2+) | .yarnrc.yml: npmRegistryServer: "https://registry-bridge.viteplus.dev/" |
Then pin the build (vite aliases to vite-plus-core; pnpm can use a catalog, npm an overrides entry):
{
"devDependencies": {
"vite-plus": "0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826",
"vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.b808fa85316443c28dc075bf6365b875ba00d826"
}
}Vite+ 1.7.0 runs type-aware linting and type checking on tsrs, a Rust port of the TypeScript 7 compiler, gives `@voidzero-dev/vite-plus-core` a version that encodes the bundled Vite version (`8.3.8000` for Vite `8.3.8`) so compatible `vite` plugins pass peer checks, and adds `vp check --fix-dangerously`. ### Features - Type-aware linting and type checking in `vp lint` and `vp check` use [tsrs](https://github.com/oxc-project/tsrs), a Rust port of the TypeScript 7 compiler, through its `tsrs-lint` executable. Commands and configuration stay the same, and `tsrs` installs with `vite-plus`. In the [benchmark](https://github.com/voidzero-dev/vite-plus/blob/main/bench/tsrs-lint.md) on two projects, with the same CLI and Oxlint, type-aware `vp lint` and a full `vp check` took 18% to 53% less time with tsrs than with the previous backend, and used about half the peak memory ([docs](https://viteplus.dev/guide/lint#type-aware-linting)) ([#3352](#3352)), by @fengmk2: - tsrs targets TypeScript `7.1.0-beta`, so type-check diagnostics can change. - With `trustPolicy: no-downgrade` in `pnpm-workspace.yaml`, pnpm rejects the bundled `tsrs` release ([upstream issue](oxc-project/tsrs#945)). `vp migrate` adds `tsrs@7.1.0-beta.tsrs2` to `trustPolicyExclude`, so run it if this policy blocks the upgrade. - `@voidzero-dev/vite-plus-core` has a version that encodes the bundled Vite version: `8.3.8000` for Vite `8.3.8` in this release. Projects alias `vite` to this package, so plugins whose `vite` peer range includes the bundled Vite, such as `@vitejs/plugin-react` with `^8.0.0`, now pass peer checks. npm no longer prints `ERESOLVE overriding peer dependency` warnings, and npm and Bun projects that declare only `vite-plus` install one copy of Vite for Vitest and Vite+, about 20 MiB less in `node_modules` on macOS arm64 ([#3317](#3317)), by @fengmk2: - On pnpm 10.2.0 and later, `vp migrate` removes the broad `vite` rule from `peerDependencyRules`. A plugin whose `vite` peer range excludes the bundled Vite then reports a peer warning, and with `strictPeerDependencies` the install fails. Update that plugin, or allow its range for that plugin only ([migration rules](https://viteplus.dev/guide/migrate-rules#pnpm)). - `vite-plus` and the core no longer share a version number. If you update them by hand or with a dependency bot, read the alias with `npm view vite-plus@1.7.0 dependencies.vite`, or run `vp migrate` to update both ([docs](https://viteplus.dev/guide/upgrade-project#manually-updating)). - `vp check --fix-dangerously` formats files and applies all lint fixes, including dangerous fixes and suggestions. It does not need `--fix`, and it works with `--no-fmt` and `--continue-on-error`. Review the changes before you commit them, because dangerous fixes can change program behavior ([docs](https://viteplus.dev/guide/check#usage)) ([#3413](#3413)), by @chbaefront. - `vp create` with a third-party `create-xxx` template asks about agent instructions, editor configs, Git, and commit hooks after the template's own CLI finishes, and checks what that CLI generated: it offers to append to an existing agent file, merges existing editor configs, and asks about Git only when the template did not create a repository. When the generated standalone project already depends on `vite-plus`, `vp create` keeps the template's choices, such as ESLint or its `vite-plus` version, and skips the migration. Set `VP_FORCE_MIGRATE=1` to run it ([#3424](#3424), [#3435](#3435)), by @liangmiQwQ. - Upgrade the bundled Vite, Rolldown, oxc-node, Oxlint, Oxfmt, and lint-staged ([#3436](#3436), [#3440](#3440), [#3452](#3452), [#3463](#3463), [#3470](#3470)), by @voidzero-guard[bot] and @fengmk2: - `vite@8.3.7` to `vite@8.3.8`. Vite rejects CSS entry points when `build.cssCodeSplit` is `false`, imports Sass once instead of once per file, and no longer opens a console window for `yarn config get` on Windows. - `rolldown@1.2.18` to `rolldown@1.2.19`. The `linux-x64-gnu` binding runs on older CPUs. - `oxc-node@1.0.1` to `oxc-node@1.0.2`, the loader behind `vpx` for TypeScript files and `vite-plus/register`. TypeScript files with `import` and `export` in a CommonJS package run as CommonJS when tsconfig compiles them to CommonJS, `package.json` `"type"` selects the format of `.ts` files under `module: node16` and `nodenext`, and `vpx --watch` on macOS no longer uses more memory each time a watched folder is replaced. - `oxlint@1.93.0` to `oxlint@1.94.0`. Many fixes that can change program behavior are now suggestions or dangerous fixes, so `vp check --fix` applies fewer of them, and `vp check --fix-dangerously` applies them. `typeCheck` is no longer experimental, and `no-misused-promises` gets a `flagUnions` option. - `oxfmt@0.78.0` to `oxfmt@0.79.0`. Oxfmt moves to Prettier 3.10.1 and fixes the output for several TypeScript, Vue, Angular, HTML, Markdown, CSS, and GraphQL cases, so formatting can change. - `lint-staged@17.6.0` to `lint-staged@17.6.1` in `vp staged`. The warning about hidden partially staged changes appears only when the changes are restored. - The new Oxfmt, Oxlint, and tsrs can flag code that passed before. If your CI runs `vp check`, run `vp check --fix --continue-on-error` after you upgrade: it formats files, applies the available lint fixes, formats again, and reports every error that remains. ### Fixes & Enhancements - `vp upgrade` no longer deletes a version directory that it did not create when an installation fails, so `vp upgrade --rollback` still finds the previous version after a failed reinstall. `vp upgrade`, `vp upgrade --rollback`, and installer setup wait for each other, so two upgrades that run at the same time can no longer leave `current` pointing to a missing directory. `vp upgrade` also repairs an active version whose `vp` binary is missing ([#3412](#3412)), by @jong-kyung and @fengmk2. - An empty `VP_NODE_SKIP_SIGNATURE_VERIFY`, `VP_NODE_DIST_MIRROR`, or `npm_config_registry` (in either letter case) counts as unset, as in pnpm. Before, `VP_NODE_SKIP_SIGNATURE_VERIFY=""` turned off PGP verification of Node.js downloads, and an empty mirror or registry failed with `relative URL without a base` ([#3444](#3444)), by @jong-kyung. - With a token for the default npm registry in `.npmrc`, the package-manager shims again use cached dist-tags for a `latest` default and fall back to the cache offline, instead of waiting on the registry at each call and failing when it cannot be reached. Other authenticated registries still skip the cache ([#3457](#3457)), by @liangmiQwQ. - `vp pack` uses `pack.envPrefix` from `vite.config.ts`. Before, the default prefixes `VITE_PACK_` and `TSDOWN_` always replaced it, so variables under the configured prefix were not inlined and variables under the default prefixes were. The `--env-prefix` flag still takes precedence ([#3454](#3454)), by @jong-kyung. - `vp migrate --full` on a project that the first migration left on ESLint and Prettier no longer loses their settings. When `vite.config.ts` holds only the default `lint` and `fmt` blocks that `vp migrate` added, the converted settings replace them. When those blocks have your own settings, the converted `.oxlintrc.json` or Prettier stays in place with a warning ([#3464](#3464)), by @jong-kyung. - `vp migrate` writes `npmPreapprovedPackages` to `.yarnrc.yml` only for Yarn 4.10.0 and later. Older Yarn versions do not know this key and refused to run, so migrated Yarn 2 and 3 projects, and Yarn 4.0 to 4.9 projects whose Yarn upgrade failed, could not install ([#3443](#3443)), by @jong-kyung. - `vp migrate` merges the duplicate `vite-plus` imports that it creates when it rewrites `vite` imports, so `import/no-duplicates` no longer reports them. Comments, side-effect imports, and code between the imports stay in place ([#3439](#3439)), by @voidzero-bot[bot] and @fengmk2. - A second `vp migrate` run keeps `oxlint` in the `dependencies` of a package that publishes an Oxlint plugin, as the first run does ([#3462](#3462)), by @jong-kyung. - `vp migrate` warns when the root or a workspace package has `turbo.json`, `turbo.jsonc`, or a `turbo` dependency, because `vp run` does not read Turborepo configuration. The warning links to the task and cache guides for manual migration ([#3300](#3300)), by @voidzero-bot[bot] and @fengmk2. - When `vp create` adds a third-party template to a monorepo, it rewrites the new package's `vite` imports to `vite-plus`, so `vp check` no longer reports `vite-plus/prefer-vite-plus-imports` errors there ([#3282](#3282)), by @voidzero-bot[bot] and @fengmk2. - New monorepos from `vp create` reference their dependency catalog entries with `catalog:` and contain no unused entries, and the TypeScript and `@types/node` catalog versions match the generated packages ([#3393](#3393)), by @d4rshnn. - `vp create` works in projects pinned to Yarn 1.x: it runs templates with `npx --yes`, as `vp dlx` does, because Yarn Classic has no `yarn dlx` ([#3468](#3468)), by @jong-kyung. - `vp env exec --node` and `vp env pin` accept `lts/*`, `lts/<codename>`, and `lts/-n`, as `vp env use` does. `vp env pin lts/*` writes the resolved exact version ([#3437](#3437)), by @jong-kyung. - Ctrl+C or `SIGTERM` during a spinner in `vp create` and `vp migrate` ends the command by that signal, so the shell reports 130 or 143 instead of 0, as for the native spinners since 1.6.0. Escape no longer ends the command while a spinner is visible ([#3432](#3432)), by @jong-kyung. - The Vitest resolver that `defineConfig` adds declares a `resolveId` filter, so Rolldown builds skip it without a call into JavaScript for imports other than `vitest`, `vitest/*`, `@vitest/*`, and `vite-plus/test`. A synthetic build with 40,000 `resolveId` calls and no other work took 1.4 s instead of 1.9 s ([#3434](#3434)), by @jasonkuhrt. ### Docs - Name `vp test` together with `vp build` as commands that support cooperative tracking in the cache guide ([#3453](#3453)), by @SaKaNa-Y. - Explain in the create guide what to do when no template fits: run the framework's own initializer, then follow the `vp migrate` guide ([#3456](#3456)), by @fengmk2. ### Chore - Update npm dependencies. New generator projects from `vp create vite:generator` depend on `bingo@^0.16.0` ([#3392](#3392)), by @renovate[bot]. - Update Rust dependencies, including `syn` 3 and `testing_macros` 2 ([#3312](#3312), [#3460](#3460), [#3461](#3461)), by @renovate[bot]. - The issue triage bot uses Conventional Commits PR titles and leaves assigned issues to their assignees ([#3459](#3459), [#3458](#3458)), by @liangmiQwQ. - Compare `User-Agent` header names case-insensitively in an HTTP test ([#3469](#3469)), by @liangmiQwQ. - Refine the release-manager skill from the v1.5.0, v1.5.1, and v1.6.0 releases ([#3348](#3348)), by @fengmk2. ### Bundled Versions | Tool | Version | Source | Changelog | | -------- | ------------------ | ---------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------- | | vite | `8.3.8` | [`b39e6e6`](vitejs/vite@b39e6e6) | [8.3.8](https://github.com/vitejs/vite/releases/tag/v8.3.8) | | rolldown | `1.2.19` | [`b9c75dd`](rolldown/rolldown@b9c75dd) | [1.2.19](https://github.com/rolldown/rolldown/releases/tag/v1.2.19) | | oxc-node | `1.0.2` | [`16c0f34`](oxc-project/oxc-node@16c0f34) | [1.0.2](https://github.com/oxc-project/oxc-node/releases/tag/v1.0.2) | | tsdown | `0.23.4` | [npm](https://npmx.dev/package/tsdown/v/0.23.4) | unchanged | | vitest | `5.1.0` | [npm](https://npmx.dev/package/vitest/v/5.1.0) | unchanged | | oxlint | `1.94.0` | [npm](https://npmx.dev/package/oxlint/v/1.94.0) | [1.94.0](https://github.com/oxc-project/oxc/releases/tag/oxlint_v1.94.0) | | tsrs | `7.1.0-beta.tsrs2` | [npm](https://npmx.dev/package/tsrs/v/7.1.0-beta.tsrs2) | [7.1.0-beta.tsrs2](https://github.com/oxc-project/tsrs/releases/tag/v7.1.0-beta.tsrs2) (replaces oxlint-tsgolint) | | oxfmt | `0.79.0` | [npm](https://npmx.dev/package/oxfmt/v/0.79.0) | [0.79.0](https://github.com/oxc-project/oxc/releases/tag/oxfmt_v0.79.0) | ### Upgrade ```bash vp upgrade ``` In each project, run `vp migrate` to update `vite-plus`, the `vite` alias to `@voidzero-dev/vite-plus-core@8.3.8000`, and the Vitest pin together ([guide](https://viteplus.dev/guide/upgrade-project)). ### New Contributors @jasonkuhrt, @d4rshnn **Full Changelog**: v1.6.0...v1.7.0 --- For a stable release, complete the `HomebrewFormula/vp.rb` update after publication by merging the generated `release/homebrew-v1.7.0` PR. Merging this PR will trigger the release workflow. --------- Co-authored-by: voidzero-guard[bot] <278573678+voidzero-guard[bot]@users.noreply.github.com> Co-authored-by: MK (fengmk2) <fengmk2@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A failed upgrade can delete a version directory that it did not create, and concurrent installation commands can leave
currentpointing to a missing directory.For example, a user upgrades from 1.1.0 to 1.2.0. The 1.1.0 directory stays as the rollback target. The user then runs
vp upgrade 1.1.0, and dependency installation fails because the network drops. The cleanup removes the whole 1.1.0 directory, although.previous-versionstill points to it, sovp upgrade --rollbackfails.Two terminals can also run
vp upgradeat the same time. Both processes write the same<DATA>/<version>directory and use the fixedcurrent.newlink name. Process A activates the new version. Process B then records that new version in.previous-version, which removes the rollback target from the record. If B fails during the link swap, B removes the directory that A has just activated.The installation lock serializes version directories, the
currentlink,.previous-version, and old-version cleanup across cooperating Vite+ processes.Approach
An upgrade downloads and verifies the payload outside the lock. It then holds the lock while it creates the version directory, installs dependencies, swaps
current, refreshes shims, and removes old versions.create_dirand record whether this run created it. A failed install removes the directory only in that case.<DATA>/.install.lock, matching the existing externalsetup.lock.currentagain. Stop with "Already up to date" when another process has already activated the target version.vp upgrade --rollback, the standalone self-setup deploy path, and the legacyvp-setupactivation.vp upgradestarts that child throughrefresh_shimswhile it holds the lock, so taking it there would deadlock.Upgrade after this change
A and B upgrade to the same version. The lock makes installation and activation run in sequence.
sequenceDiagram participant A as Upgrade process A participant L as Installation lock participant B as Upgrade process B Note over A,B: Both processes download and verify the payload in parallel A->>L: A acquires the lock Note over A: A installs and activates the version<br/>A records the old version for rollback B->>L: B requests the lock Note over B: B waits A->>L: A releases the lock L-->>B: B acquires the lock Note over B: B reads current again<br/>The target is already active B->>L: B reports that it is up to date and releases the lock Note over A,B: The rollback target and the active directory remain intactReferences
crates/vp_global_cli/src/self_setup/external.rsuses the same blocking lock for external installations.