Repository navigation
Conversation
`Arch::current()` rejects every target other than x86_64 and aarch64 with a `compile_error!`, so `vp` cannot be built on PowerPC at all. Add `Arch::Ppc64` (big-endian) and `Arch::Ppc64le` (little-endian), selected by `target_endian` because Rust uses the single target_arch "powerpc64" for both. Their names follow Node.js's own `process.arch` spelling, so on Linux ppc64le the managed runtime resolves the official `node-v<version>-linux-ppc64le.tar.gz`. Node.js publishes no big-endian Linux build. On ppc64 the download stops before fetching any archive, with "Hash not found for node-v<version>-linux-ppc64.tar.gz in SHASUMS256.txt", while a VP_NODE_DIST_MIRROR that carries such builds works unchanged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arch::current()rejects every target other than x86_64 and aarch64with a
compile_error!, sovpcannot be built on PowerPC at all.Add
Arch::Ppc64(big-endian) andArch::Ppc64le(little-endian),selected by
target_endianbecause Rust uses the single target_arch"powerpc64" for both. Their names follow Node.js's own
process.archspelling, so on Linux ppc64le the managed runtime resolves the official
node-v<version>-linux-ppc64le.tar.gz.Node.js publishes no big-endian Linux build. On ppc64 the download
stops before fetching any archive, with "Hash not found for
node-v-linux-ppc64.tar.gz in SHASUMS256.txt", while a
VP_NODE_DIST_MIRROR that carries such builds works unchanged.