Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/cli/src/__tests__/define-config-plugins.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,16 @@ describe('defineConfig project plugin injection', () => {
]);
});

// https://github.com/voidzero-dev/vite-plus/issues/3152
it('keeps async plugins as-is so their own properties survive', () => {
// Mirrors `vike()`, which tags its plugin promise for config discovery.
const vikePlugin = Object.assign(Promise.resolve([{ name: 'vike' }]), {
_vikeVitePluginOptions: {},
});
const config = defineConfig({ plugins: [vikePlugin] });
expect(config.plugins![4]).toBe(vikePlugin);
});

it('injects nested independent projects in referenced defineProject configs', () => {
const config = defineProject({
test: {
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/src/define-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -851,8 +851,9 @@ function withoutVitePlusTestPlugins(plugin: PluginOption): PluginOption {
if (Array.isArray(plugin)) {
return plugin.filter(keepUserPlugin).map(withoutVitePlusTestPlugins);
}
// Injected plugins are never async, and re-wrapping with `.then` drops own props that tools like Vike look up.
if (plugin instanceof Promise) {
return plugin.then(withoutVitePlusTestPlugins);
return plugin;
}
return plugin && VITE_PLUS_TEST_PLUGIN_NAMES.has(plugin.name) ? false : plugin;
}
Expand Down
Loading