fix(cli): declare playwright peer for copied provider types - #2865
Open
liangmiQwQ wants to merge 2 commits into
Open
liangmiQwQ wants to merge 2 commits into
liangmiQwQ wants to merge 2 commits into
Conversation
liangmiQwQ
marked this pull request as ready for review
October 2, 2026 00:28
liangmiQwQ
requested review from
Brooooooklyn and
fengmk2
and removed request for
Brooooooklyn
October 2, 2026 02:53
fengmk2
pushed a commit
that referenced
this pull request
Oct 3, 2026
The Node API snapshot can fail when Vitest's JSON and blob reporters finish writing in a different order, as seen in [CI for #2865](https://github.com/voidzero-dev/vite-plus/actions/runs/36882680402/job/110442181616). Vitest invokes reporters concurrently, so their completion messages have no fixed order. Capture this runner's stdout through Vitest's public option and sort the lines before printing them for the snapshot. All completion messages and existing report-content assertions remain checked. 🤖 Generated with Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2854
This PR adds
playwrightas an optional peer ofvite-plus, matching the upstream provider's*range. The copied provider declarations import Playwright types directly, so isolated dependency layouts need this peer to preserve option type checking even withskipLibCheckenabled.🤖 Generated with Codex