Skip to content

feat(editor): disable nested Oxlint config in generated settings - #2331

Merged
fengmk2 merged 5 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-generated-oxc-nested-config
Aug 6, 2026
Merged

feat(editor): disable nested Oxlint config in generated settings#2331
fengmk2 merged 5 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/fix-generated-oxc-nested-config

Conversation

@liangmiQwQ

@liangmiQwQ liangmiQwQ commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

We'd better wait for oxc-project/oxc-vscode to ship oxc.fmt.disableNestedConfig to replace 'oxc.fmt.configPath': './vite.config.ts' there? /cc @Sysix

Follow-up to #2245

@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit e047aaf
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a7429f398c1f300081c507e

@Sysix

Sysix commented Aug 5, 2026

Copy link
Copy Markdown

@liangmiQwQ oxc.fmt.disableNestedConfig is now released:
https://github.com/oxc-project/oxc-vscode/releases/tag/v1.60.0

@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@Sysix Thank you!

@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 26ece3e656

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@liangmiQwQ
liangmiQwQ marked this pull request as ready for review August 6, 2026 03:04
@liangmiQwQ
liangmiQwQ requested a review from leaysgur August 6, 2026 03:04

@leaysgur leaysgur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@liangmiQwQ
liangmiQwQ requested a review from fengmk2 August 6, 2026 03:38
@fengmk2 fengmk2 self-assigned this Aug 6, 2026
@fengmk2
fengmk2 merged commit 89704f7 into voidzero-dev:main Aug 6, 2026
46 checks passed
@liangmiQwQ
liangmiQwQ deleted the liang/codex/fix-generated-oxc-nested-config branch August 6, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants