Skip to content

feat(cli): prompt for node mismatch reinstall#1666

Open
liangmiQwQ wants to merge 3 commits into
voidzero-dev:mainfrom
liangmiQwQ:codex/resolve-1598-node-mismatch
Open

feat(cli): prompt for node mismatch reinstall#1666
liangmiQwQ wants to merge 3 commits into
voidzero-dev:mainfrom
liangmiQwQ:codex/resolve-1598-node-mismatch

Conversation

@liangmiQwQ
Copy link
Copy Markdown
Contributor

@liangmiQwQ liangmiQwQ commented May 23, 2026

Close #1598

This PR adds a prompt logic for all up-to-date global packages with a Node.js version mismatch to ask users whether to reinstall packages with the current Node. The prompt defaults to N.

This PR also adds --reinstall-node-mismatch and --ignore-node-mismatch. In CI or non-interactive environments, Reinstall will be skipped the and warns that users can pass --reinstall-node-mismatch to force it.

🤖 Generated with Codex

@netlify
Copy link
Copy Markdown

netlify Bot commented May 23, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 2b5f542
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a1619b6ae444b0008ff5cbd

@liangmiQwQ liangmiQwQ changed the title fix(global): prompt for node mismatch reinstall feat(global): prompt for node mismatch reinstall May 23, 2026
@liangmiQwQ liangmiQwQ force-pushed the codex/resolve-1598-node-mismatch branch from 65d56b1 to 2be7684 Compare May 23, 2026 03:47
@liangmiQwQ liangmiQwQ changed the title feat(global): prompt for node mismatch reinstall feat(cli): prompt for node mismatch reinstall May 23, 2026
@liangmiQwQ
Copy link
Copy Markdown
Contributor Author

liangmiQwQ commented May 23, 2026

Waiting for #1659.

Update: #1659 gets merged.

@liangmiQwQ liangmiQwQ force-pushed the codex/resolve-1598-node-mismatch branch from daa6bf3 to 12090e6 Compare May 26, 2026 15:13
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 26, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​dialoguer@​0.12.010010094100100

View full report

@liangmiQwQ liangmiQwQ marked this pull request as ready for review May 26, 2026 21:54
@liangmiQwQ
Copy link
Copy Markdown
Contributor Author

@codex

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12090e6a39

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_global_cli/src/cli.rs Outdated
@liangmiQwQ
Copy link
Copy Markdown
Contributor Author

@codex

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prompt users whether to reinstall a package installed by a different node version in vp update -g

1 participant