You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(queries): class expression as a query predicate (@ViewChild(class Foo {})) is rejected or dropped #516
At the #504 tip, crates/oxc_angular_compiler/src/directive/property_decorators.rs (~L1917, added by #495) evaluates the predicate to Value::Dynamic and then calls convert_oxc_expression. That returns None for a class expression (output/oxc_converter.rs has no ClassExpression case), so it reports "predicate cannot be interpreted". On main the same None makes the query disappear silently. In ngtsc (annotations/directive/src/shared.ts, extractQueryMetadata), a predicate that evaluates to a Reference or a DynamicValue is emitted as written (new WrappedNodeExpr(node)). A class expression is a DynamicValue. "predicate cannot be interpreted" is only for values that are neither strings nor string arrays.
Direction
Let convert_oxc_expression emit a class expression as raw source with types stripped. The predicate path then works without changes.
On main?
Yes, but differently: main drops the query silently, the stack reports an error. Low priority; class-expression predicates are rare.
Activity