Disable SyntaxError tests in preparation for CL#99
Merged
hashseed merged 1 commit intov8:node-ci-2019-04-29from May 16, 2019
Merged
Disable SyntaxError tests in preparation for CL#99hashseed merged 1 commit intov8:node-ci-2019-04-29from
hashseed merged 1 commit intov8:node-ci-2019-04-29from
Conversation
Author
|
PTAL @psmarshall |
hashseed
approved these changes
May 16, 2019
Member
|
LGTM. Thanks. You need to also update the DEPS file in node-ci too to point to this new commit though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily disabled tests affected by this CL.
I'm not sure I selected the right destination branch here. I'm hoping to make the change such that I can immediately have the trybot succeed after updating
node-ci.