Skip to content

stdbuf: harden no-fork cmdline polling#12499

Open
puneetdixit200 wants to merge 1 commit into
uutils:mainfrom
puneetdixit200:fix/stdbuf-no-fork-cmdline-poll
Open

stdbuf: harden no-fork cmdline polling#12499
puneetdixit200 wants to merge 1 commit into
uutils:mainfrom
puneetdixit200:fix/stdbuf-no-fork-cmdline-poll

Conversation

@puneetdixit200
Copy link
Copy Markdown

Summary:

  • make the no-fork regression test wait until /proc cmdline resolves to the expected sleep target
  • add coverage for the transient /target/x86_64-unknown-linux-gnu cmdline value observed in CI
  • keep the change scoped to the stdbuf test polling logic

Tests:

  • CARGO_HOME=/private/tmp/uutils-stdbuf-cargo-home CARGO_TARGET_DIR=/private/tmp/uutils-stdbuf-target cargo test -q --features stdbuf,test_risky_names --no-default-features test_stdbuf_cmdline_poll_ignores_transient_target_prefix
  • docker run --rm ... rust:1.88-bookworm cargo test -q --features stdbuf,test_risky_names --no-default-features test_stdbuf (14 passed)
  • CARGO_HOME=/private/tmp/uutils-stdbuf-cargo-home CARGO_TARGET_DIR=/private/tmp/uutils-stdbuf-target cargo clippy -q --features stdbuf,test_risky_names --no-default-features --test tests -- -D warnings
  • cargo fmt --all -- --check
  • git diff --check

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/bounded-memory is now being skipped but was previously passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant