Skip to content

feat: support for tap to reload on PWA#1827

Merged
boojack merged 3 commits intomainfrom
feat/tap_to_reload
Jun 14, 2023
Merged

feat: support for tap to reload on PWA#1827
boojack merged 3 commits intomainfrom
feat/tap_to_reload

Conversation

@athurg
Copy link
Copy Markdown
Contributor

@athurg athurg commented Jun 14, 2023

While we use Memos on a mobile device, the browser support pull-down to reload the page. But if we place Memos as a PWA applications, there is no refresh button or pull-down support. So I just add a tap-to-reload in the nav bar.

This PR also resolved #1789 .

@athurg athurg requested a review from boojack as a code owner June 14, 2023 03:31
@athurg athurg linked an issue Jun 14, 2023 that may be closed by this pull request
@athurg athurg force-pushed the feat/tap_to_reload branch from 02611cb to d077a6b Compare June 14, 2023 03:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 14, 2023

Uffizzi Preview deployment-28467 was deleted.

@athurg athurg self-assigned this Jun 14, 2023
@athurg athurg added enhancement New feature or request frontend labels Jun 14, 2023
@athurg athurg force-pushed the feat/tap_to_reload branch from 52a4ada to 3f81c66 Compare June 14, 2023 11:12
@athurg athurg force-pushed the feat/tap_to_reload branch from 3f81c66 to cc1682a Compare June 14, 2023 11:17
@athurg athurg requested a review from Zeng1998 June 14, 2023 11:22
@boojack
Copy link
Copy Markdown
Member

boojack commented Jun 14, 2023

Maybe we can use the title element as trigger. WDYT?

image

@athurg
Copy link
Copy Markdown
Contributor Author

athurg commented Jun 14, 2023

Maybe we can use the title element as trigger. WDYT?

image

Of course. I think it was used for open the sidebar before. But I checked it again, and the title has not bind to click event.

I have move the link on the site title.

@boojack boojack changed the title feat: Add suppport for tap to reload on PWA feat: support for tap to reload on PWA Jun 14, 2023
@boojack boojack merged commit 7694597 into main Jun 14, 2023
@athurg athurg deleted the feat/tap_to_reload branch June 14, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

能不能在memos图标旁边加个刷新按钮,或者下拉刷新?

3 participants