Skip to content

feat(app): add ability to edit question on questions page and single question page for admin - #502

Merged
typeofweb merged 26 commits into
developfrom
479-issue
Jan 24, 2023
Merged

typeofweb merged 26 commits into
developfrom
479-issue

Conversation

@grzegorzpokorski

@grzegorzpokorski grzegorzpokorski commented Jan 13, 2023 •

Copy link
Copy Markdown
Member

PR wprowadza zmiany:

  • dla adminów dodano możliwość edytowania pytań na stronie 'głównej' oraz na stronie pojedynczego pytania (Przycisk do edycji pytania dla adminów #479),
  • w panelu użytkownika podobnie, jak w panelu admina, po edycji pytania, lista pytań jest odświeżana, aby można było zobaczyć wprowadzone zmiany,
  • dodano ścieżkę do pliku konfiguracyjnego prettiera do ustawień workspace vsc.
  • dodano inną wersję loadera w stylu skeleton do zastosowania na stronach, gdzie ładowane są pytania.

@vercel

vercel Bot commented Jan 13, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
devfaq ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 7:08PM (UTC)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-cci2u1ky8-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions

github-actions Bot commented Jan 13, 2023 •

Copy link
Copy Markdown

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 83.38 KB (🟡 +62 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Comment thread apps/app/src/components/SingleQuestion.tsx Outdated

@github-actions github-actions Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-3rrrq2bhp-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@grzegorzpokorski
grzegorzpokorski marked this pull request as draft January 14, 2023 19:24

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-13g35vtlz-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-jrjoaqcc7-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-ovkvt93nn-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-b6p4m4q12-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-e0257tx2s-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-7r0oljn3m-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Comment thread apps/app/src/components/Loading.tsx Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-5ohj4nko3-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Comment thread apps/app/src/components/UserQuestions/UserQuestionLeftSection.tsx Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-6fjbrr3r7-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-9ra695706-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@typeofweb
typeofweb merged commit 7c98b84 into develop Jan 24, 2023
@typeofweb
typeofweb deleted the 479-issue branch January 24, 2023 21:47
typeofweb pushed a commit that referenced this pull request Sep 9, 2026
…question page for admin (#502)

* feat(app): add ability to edit questions on questions list to admin

* feat(app): add ability to edit question on question page to admin

* fix(app): refetch questions after edit one of them in user panel

* fix(app): fix text align in "CtaHedaerActiveLink"

* Remove unused import

* chore: add prettier config file to worspace config

* fix: update questions list after edit any of them in user dashboard

* fix: add loading indicator to questions list in dashboards

* fix: disable ssr for QuestionsManagement on questions pages

* fix: small improvements in "EditAnswer" and "AnswerForm"

* fix: remove unused import

* fix: refresh ssr generated page after edit question

* fix: remove unused import

* fix: fix vercel deployment

* fix: rename function name "customOnClose" => "additionalActionOnClose"

* feat: change loading indicator component

* fix: improve "Loading" component styles

* fix: improve loader a11y

* fix: improve styles of "Loading" component

* fix: improve light theme of loading component

* Update apps/app/src/components/Loading.tsx

* implement "additionalActionOnClose" function in dashboard modals

* improve loading component and implement this changes

This branch was successfully deployed

1 active deployment
Preview — 2d109c53 Deployed Jan 23, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants