Repository navigation
feat(app): add user context menu - #495
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-p7n98pj17-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-kwfnwtvny-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-i69hv4j8j-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-end654rav-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-4yil0cccr-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
| aria-expanded={isDropdownVisible} | ||
| aria-controls="user-menu" | ||
| > | ||
| <div className="relative h-12 w-12 sm:h-6 sm:w-6"> |
There was a problem hiding this comment.
Trochę małe zdjęcie na desktopie
There was a problem hiding this comment.
Przy dobieraniu rozmiaru zdjęcia sugerowałem się tym, aby zachować symetrie w tym menu, ale zgadzam się, że nie wygląda to może do końca tak, jak powinno. Nie miałem innego pomysłu.
Zastanawia mnie również to, czy to menu kontekstowe nie jest trochę niepotrzebne, bo kolejne opcje dodawane sią do "menu" w komponencie CtaHeader. Moim zdaniem można by to jakoś ujednolicić. Jeśli w CtaHeader znajdzie się więcej opcji to będzie trzeba pomyśleć o jego przebudowie szczególnie na smartfony. Możnaby ewentualnie część opcji związanych z użytkownikiem przerzucić do menu kontekstowego 🤔
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
…devfaq into 476-user-context-menu
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-a81i560v7-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-8yquzliv6-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
| Device | URL |
|---|---|
| mobile | https://devfaq-dc63wjsie-typeofweb.vercel.app |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
* feat(app): add user context menu * feat(app): improvements related to UserMenu * fix(app): add aria attributes to 'UserMenu' and remove unused imports * fix(app): user avatar size adjustments * refactor(app): refactor html structure in 'UserMenu' * refactor(app) remove unused import from "UserAvatar" * Update apps/app/src/hooks/useIsAboveBreakpoint.ts Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl> * Update apps/app/src/hooks/useIsAboveBreakpoint.ts Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl> * Update apps/app/src/components/Header/UserMenu.tsx Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl> * Update apps/app/src/components/Header/UserMenu.tsx Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl> * Update apps/app/src/components/Header/UserMenu.tsx Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl> * refactor(app): remove span tag from "LoginNavigationLink" * refactor(app): remove span tag from button content in 'UserMenu' Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>
This branch was successfully deployed
2 participants
Propozycja do #476 issue. Poniżej screeny, jak to wygląda: