Skip to content

fix(app): change logout trigger - #486

Merged
typeofweb merged 5 commits into
developfrom
fix-logout-button
Jan 5, 2023
Merged

typeofweb merged 5 commits into
developfrom
fix-logout-button

Conversation

@grzegorzpokorski

@grzegorzpokorski grzegorzpokorski commented Jan 4, 2023 •

Copy link
Copy Markdown
Member

Wstawiłem obrazek powodujący wylogowanie z serwisu do buttona oraz dodatkowo dodałem etykietę. Dzięki temu element zyskał focus oraz zyskał bardziej semantyczne znaczenie na stronie.

@vercel

vercel Bot commented Jan 4, 2023 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
devfaq ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 0:53AM (UTC)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-4c0g0gveb-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@github-actions

github-actions Bot commented Jan 4, 2023 •

Copy link
Copy Markdown

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

Comment thread apps/app/src/components/Header/UserAvatar.tsx Outdated
grzegorzpokorski and others added 2 commits January 5, 2023 01:41
Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-7meq1flgv-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@sonarqubecloud

sonarqubecloud Bot commented Jan 5, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile https://devfaq-oxn92me54-typeofweb.vercel.app

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@typeofweb
typeofweb merged commit 13bfdbf into develop Jan 5, 2023
@typeofweb
typeofweb deleted the fix-logout-button branch January 5, 2023 17:47
typeofweb added a commit that referenced this pull request Sep 9, 2026
* fix(app): change logout trigger

* fix(app): add accessible name to logout button

* Update apps/app/src/components/Header/UserAvatar.tsx

Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>

* fix typo

Co-authored-by: Michał Miszczyszyn <michal@mmiszy.pl>

This branch was successfully deployed

1 active deployment
Preview — b85c41a5 Deployed Jan 5, 2023 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants