Go: Reset connection when it's returned to a pool - #1100
Merged
Conversation
Contributor
Author
|
@penberg @LucioFranco I'm changing public API in |
haaawk
force-pushed
the
reset_connection
branch
5 times, most recently
from
February 29, 2024 07:41
7a3482a to
95521c3
Compare
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
Signed-off-by: Piotr Jastrzebski <piotr@chiselstrike.com>
haaawk
force-pushed
the
reset_connection
branch
from
February 29, 2024 08:27
95521c3 to
da62b4f
Compare
haaawk
added this pull request to the merge queue
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go has a pool of connections.
We need to reset baton in the connection every time it's returned to the pool.
Otherwise, user gets STREAM EXPIRED errors a lot.
This depends on #1099