Skip to content

feat: Add $not to eventFilters - #815

Merged
matt-aitken merged 3 commits into
triggerdotdev:mainfrom
meetwithyash:feat/not-event-filter
Jan 2, 2024
Merged

feat: Add $not to eventFilters#815
matt-aitken merged 3 commits into
triggerdotdev:mainfrom
meetwithyash:feat/not-event-filter

Conversation

@meetwithyash

Copy link
Copy Markdown
Contributor

Closes #810

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Changelog

  • not filter added in event filters

@changeset-bot

changeset-bot Bot commented Dec 27, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e231269

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matt-aitken matt-aitken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a false test as well?

Comment thread packages/core/test/eventFilterMatches.test.ts
@matt-aitken
matt-aitken merged commit 740b7b2 into triggerdotdev:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1795] Add $not to eventFilters

2 participants