Skip to content

Fix for #731, integrations getting stuck if OAuth then moved to API key - #732

Merged
ericallam merged 1 commit into
mainfrom
fix/1575-integrations-stuck-oauth
Dec 14, 2023
Merged

Fix for #731, integrations getting stuck if OAuth then moved to API key#732
ericallam merged 1 commit into
mainfrom
fix/1575-integrations-stuck-oauth

Conversation

@matt-aitken

Copy link
Copy Markdown
Member

Closes #731

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  • Create an integration that's OAuth (like SendGrid)
  • Sync it to the dashboard
  • Check it's in an incomplete state on the integrations page
  • In your code add an apiKey
  • Save and sync
  • The integration should now be setup as "LOCAL"

@changeset-bot

changeset-bot Bot commented Nov 10, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 59b66dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matt-aitken

Copy link
Copy Markdown
Member Author

This needs testing

@ericallam
ericallam force-pushed the fix/1575-integrations-stuck-oauth branch from b1cd4ae to 59b66dc Compare December 14, 2023 15:58
@ericallam
ericallam merged commit 49ca4c4 into main Dec 14, 2023
@ericallam
ericallam deleted the fix/1575-integrations-stuck-oauth branch December 14, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1575] Creating an integration with OAuth then switching to API Key makes it stuck

2 participants