Skip to content

feat: allow sendEvent to update an existing event - #607

Merged
ericallam merged 1 commit into
triggerdotdev:mainfrom
hmacr:issue-604
Oct 13, 2023
Merged

feat: allow sendEvent to update an existing event#607
ericallam merged 1 commit into
triggerdotdev:mainfrom
hmacr:issue-604

Conversation

@hmacr

@hmacr hmacr commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

Closes #604

✅ Checklist

  • I have followed every step in the contributing guide
  • The PR title follows the convention.
  • I ran and tested the code works

Testing

  • Verified event creation and subsequent run.
    • without deliverAt / deliverAfter.
    • with deliverAt / deliverAfter.
  • Verified event updation and subsequent run.
    • without deliverAt / deliverAfter.
    • with deliverAt / deliverAfter.
  • Verified event doesn't get updated when it is within the threshold window.

Changelog

  • Implement event update for duplicate requests.
  • Use a threshold window to determine if the update should proceed.

💯

@changeset-bot

changeset-bot Bot commented Oct 11, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a93e1b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericallam
ericallam merged commit 6371dd4 into triggerdotdev:main Oct 13, 2023
@ericallam

Copy link
Copy Markdown
Member

@hmacr great work on this 👏. If you are interested could you take a look at this issue: #604

@hmacr

hmacr commented Oct 15, 2023

Copy link
Copy Markdown
Contributor Author

@hmacr great work on this 👏. If you are interested could you take a look at this issue: #604

@ericallam The issue referenced, points to the one that's resolved by this PR. Did you mean to link a different issue?

@ericallam

Copy link
Copy Markdown
Member

@hmacr oops, I meant to link to this one: #565

@hmacr

hmacr commented Oct 15, 2023

Copy link
Copy Markdown
Contributor Author

@hmacr oops, I meant to link to this one: #565

@ericallam Sure! I'll have a look 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TRI-1395] Calling sendEvent with a duplicate ID and a deliverAt or deliverAfter option should update the existing event

2 participants