Skip to content

feat(plugins): add SSO plugin contract to @trigger.dev/plugins#3949

Merged
0ski merged 2 commits into
mainfrom
oskar/feat-sso-plugin-contract
Jun 15, 2026
Merged

feat(plugins): add SSO plugin contract to @trigger.dev/plugins#3949
0ski merged 2 commits into
mainfrom
oskar/feat-sso-plugin-contract

Conversation

@0ski

@0ski 0ski commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@0ski 0ski marked this pull request as ready for review June 15, 2026 11:09
@changeset-bot

changeset-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f0f3343

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 84b46802-af32-4894-b2da-064a4a05a732

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

A new sso.ts module is added to packages/plugins/src/ defining vendor-neutral SSO domain types (SsoConnectionState, SsoDomainState, OrgSsoStatus, SsoFlow, SsoProfile, SsoRouteDecision, SsoResolutionDecision), the SSO_FLOWS constant, typed error unions for the auth lifecycle and webhooks (SsoDecisionError, SsoBeginError, SsoCompleteError, SsoMutationError, SsoPortalError, SsoValidateError, SsoWebhookError, SsoWebhookEvent), and the public SsoController and SsoPlugin interfaces. All exported types and the SSO_FLOWS constant are re-exported from packages/plugins/src/index.ts. The neverthrow package (^8.2.0) is added as a runtime dependency in package.json.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty; no content was provided by the author despite the template requiring multiple sections including testing, changelog, and a checklist. Complete the pull request description using the provided template, including the checklist, testing steps, changelog entry, and any relevant screenshots.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding an SSO plugin contract to the @trigger.dev/plugins package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch oskar/feat-sso-plugin-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@0ski 0ski enabled auto-merge (squash) June 15, 2026 11:10
@0ski 0ski force-pushed the oskar/feat-sso-plugin-contract branch from aae4997 to bbedcdf Compare June 15, 2026 11:11

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Jun 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@f0f3343

trigger.dev

npm i https://pkg.pr.new/trigger.dev@f0f3343

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@f0f3343

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@f0f3343

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@f0f3343

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@f0f3343

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@f0f3343

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@f0f3343

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@f0f3343

commit: f0f3343

@0ski 0ski self-assigned this Jun 15, 2026
Comment thread .changeset/sso-plugin-contract.md Outdated
Comment thread packages/plugins/src/index.ts Outdated
@0ski 0ski force-pushed the oskar/feat-sso-plugin-contract branch from 6e9d577 to 2ad9510 Compare June 15, 2026 14:27
@0ski 0ski merged commit 545ecf7 into main Jun 15, 2026
53 checks passed
@0ski 0ski deleted the oskar/feat-sso-plugin-contract branch June 15, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants