Skip to content

Add testing CLI changes guide to contributing.md - #220

Merged
ericallam merged 3 commits into
triggerdotdev:mainfrom
Ashutosh-Bhadauriya:feat/add-testingcli-changes-to-contributing
Jul 26, 2023
Merged

Add testing CLI changes guide to contributing.md#220
ericallam merged 3 commits into
triggerdotdev:mainfrom
Ashutosh-Bhadauriya:feat/add-testingcli-changes-to-contributing

Conversation

@Ashutosh-Bhadauriya

Copy link
Copy Markdown
Contributor

Related to PR #214 and issue #210

Add the guide in CONTRIBUTING.md to test the CLI changes

@changeset-bot

changeset-bot Bot commented Jul 26, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4552762

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ericallam ericallam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just one note that if you are highlighting code inline to just use a single backtick instead of a triple-backtick

@Ashutosh-Bhadauriya

Copy link
Copy Markdown
Contributor Author

Just updated it and resolved merge conflicts

@ericallam

Copy link
Copy Markdown
Member

Nice one, thanks for this!

/tip $25

@ericallam
ericallam merged commit 3cf01ff into triggerdotdev:main Jul 26, 2023
@algora-pbc

algora-pbc Bot commented Jul 26, 2023

Copy link
Copy Markdown

🎉🎈 @Ashutosh-Bhadauriya has been awarded $25! 🎈🎊

@Ashutosh-Bhadauriya
Ashutosh-Bhadauriya deleted the feat/add-testingcli-changes-to-contributing branch July 27, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants